36.69 - 36.73% basic_compositor_video (linux64-qr) regression on push fd235fdcca9ec5b1102a758e5a499d09c15376ce (Wed November 11 2020)
Categories
(Testing :: Performance, defect)
Tracking
(firefox-esr78 unaffected, firefox83 unaffected, firefox84 wontfix, firefox85 fixed)
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox83 | --- | unaffected |
firefox84 | --- | wontfix |
firefox85 | --- | fixed |
People
(Reporter: alexandrui, Assigned: lsalzman)
References
(Regression)
Details
(4 keywords)
Attachments
(3 files)
Perfherder has detected a talos performance regression from push fd235fdcca9ec5b1102a758e5a499d09c15376ce. As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
Ratio | Suite | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|---|
37% | basic_compositor_video | linux64-qr | e10s stylo webrender-sw | 2.81 -> 3.84 | |
37% | basic_compositor_video | linux64-qr | e10s stylo webrender-sw | 2.81 -> 3.84 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.
For more information on performance sheriffing please see our FAQ.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Fix an unintentional bug where I had not originally anticipated the renderer
thread to be waiting on the jobs available condition, so had avoided trying to
signal the condition. Later revisions of the patch then made the thread wait on
the condition, so it is always necessary to signal from either thread sending
jobs to make sure either thread wakes up when necessary to process jobs.
Updated•4 years ago
|
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb3a07192fc6 always signal that SwComposite jobs are available when they are sent. r=jrmuizel
Assignee | ||
Comment 3•4 years ago
|
||
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee9c16b877db always wait for SwComposite jobs to become available when job count is non-zero. r=jrmuizel
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cb3a07192fc6
https://hg.mozilla.org/mozilla-central/rev/ee9c16b877db
Assignee | ||
Comment 6•4 years ago
|
||
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/73ae54907837 cache current SwCompositeGraphNode with AtomicPtr to avoid locking mutex for every band. r=mattwoodrow
Comment 8•4 years ago
|
||
Set release status flags based on info from the regressing bug 1670328
Comment 9•4 years ago
|
||
bugherder |
Comment 10•4 years ago
|
||
The patch landed in nightly and beta is affected.
:lsalzman, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 11•4 years ago
|
||
SW-WR is not deployed yet beyond nightly, so this is not a big deal to uplift.
Description
•