1677538 - Unify the primaryToolbar.css

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

primaryToolbar.css is actually not unified and we have a lot of code tripled in the files.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1677538-unify-primaryToolbar.css.patch

A lot of code is now in the shared file.

I also remove unused code like .mail-bar3 in osx which is a class we don't have. Or also .appmenu-edit-button which was used in the old AppMenu.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9188094 [details] [diff] [review]
1677538-unify-primaryToolbar.css.patch

Review of attachment 9188094 [details] [diff] [review]:
-----------------------------------------------------------------

Great clean up, thank you so much for doing it.
Just a little nit to remove a duplicated class declaration we don't need.

::: mail/themes/windows/mail/primaryToolbar.css
@@ +349,5 @@
>  }
> +
> +.button-appmenu {
> +  margin-inline: 4px;
> +}

This .button-appmenu { margin-inline: 4px; } can be removed from both Linux and Windows files as it's already declared in the shared file.
Only macos needs the 7px variation.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1677538-unify-primaryToolbar.css.patch

(In reply to Alessandro Castellani (:aleca) from comment #2)

Comment on attachment 9188094 [details] [diff] [review]
1677538-unify-primaryToolbar.css.patch

Review of attachment 9188094 [details] [diff] [review]:

Great clean up, thank you so much for doing it.
Just a little nit to remove a duplicated class declaration we don't need.

This .button-appmenu { margin-inline: 4px; } can be removed from both Linux
and Windows files as it's already declared in the shared file.
Only macos needs the 7px variation.

Ah yes, good catch. Removed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/624e9cfcc93b
Unify the primaryToolbar.css. r=aleca