1677593 - Support try builds with custom rustc source

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Description

[Aria Beingessner [:Gankra]]

This came up in the context of wanting to do perf tests on patched versions of llvm/rustc. Presumably you would specify a git(hub) repo url somewhere and it would pull it down, build it, and install the artifacts where we would normally download them in repack_rust.py.

Haven't thought through the details.

Comment 1

[(Away)]

I think I'd prefer to have this more like our build-clang system where you specify an upstream hash and supply patch files in-tree, rather than putting patches into a personal github branch.

That said, I'm open to being outvoted on this, and also open to taking anything as a first stab since it's better than nothing.

Comment 2

[Aria Beingessner [:Gankra]]

Useful links I don't want to forget:

• clang.yml version specification with build override file
• toolchains.yml specifying clang hash to use
• clang build override file with patches to apply
• a patch file it applies

Comment 3

[Mike Hommey [:glandium]]

Please don't feel like you have to use a separate json file for patches. They could be defined in the taskcluster yml. For a first iteration, it would probably be easier to go without patches at all, though.

Comment 4

[Aria Beingessner [:Gankra]]

Attachment: Bug 1677593 - Add support for building rust from source. r?glandium

This adds a linux64-rust-dev toolchain and several git fetches of rust-lang/rust
that it can source from (stable tags for 1.43-1.47, plus a recent tip). For now
it defaults to 1.47, which most things use.

There are some issues with cross-compiling, so for now the toolchain only
builds a host build, although a lot of the machinery for cross compiling is
there for anyone brave/desperate enough to get it working.

I expect some of the things I setup in the build script aren't necessary,
but it's simple enough that I don't think it's worth kicking off 20 builds
to try to remove some redundant flags.

Also note some changes were made to Rust's config.toml between 1.47 and 1.50,
so some version detection may need to be added in the future.

There is experimental support for providing patches via a new --patch flag.

Additionally, I documented the existence of the "bors-" mode.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e2b77521ddd
Add support for building rust from source. r=glandium

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/0e2b77521ddd