1677625 - WNPanel devtools "Open What's New Panel" and "Render Selected Messages" buttons aren't working

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

+++ This bug was initially created as a clone of Bug #1673733 +++

See bug 1673733 comment 5.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1677625 - Fix the What's New panel DevTools control buttons. r?emcminn!

This was originally fixed in bug 1673733, but then re-broken with a refactor
for unit tests in bug 1673109.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8211e74c9b2d
Fix the What's New panel DevTools control buttons. r=emcminn

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8211e74c9b2d

Comment 4

[Mathew Hodson]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #1)

This was originally fixed in bug 1673733, but then re-broken with a refactor
for unit tests in bug 1673109.

This bug should probably be marked as Regressed By bug 1673109

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9188177 [details]
Bug 1677625 - Fix the What's New panel DevTools control buttons. r?emcminn!

Beta/Release Uplift Approval Request

• User impact if declined: None. However, QA / Engineering might find it more difficult to test What's New messages via the ASRouter devtools.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's in a region of the codebase that users don't tend to it - the ASRouter devtools.
• String changes made/needed: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9188177 [details]
Bug 1677625 - Fix the What's New panel DevTools control buttons. r?emcminn!

Approved for 84.0b3.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/70c1db0dfb4a

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (85.0a1 Build ID - 20201126212448) and latest Firefox Beta (84.0b5 Build ID - 20201126155845) installed on Windows 10 x64, Linux Mint 20 x64, and Mac 10.15. Now I can confirm that the "What's New" panel is opened if the "Open What's New Panel" button is clicked and that the selected message is rendered in the panel if the "Render Selected Messages" button is clicked.