[wpt-sync] Sync PR 26545 - Fix aborted AbortSignal in addEventListener
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox85 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 26545 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/26545
Details from upstream follow.
b'Joey Arhar <jarhar@chromium.org>' wrote:
Fix aborted AbortSignal in addEventListener
If you call AbortSignal.abort() and then pass that AbortSignal to
addEventListener, it shouldn't add the event listener. It currently adds
the event listener and still runs the handler, and this patch stops it
from adding the listener in that case.Fixed: 1149553
Change-Id: I7aee86d3fb2901947054c66d50e2aef1bb9467bf
Reviewed-on: https://chromium-review.googlesource.com/2541503
WPT-Export-Revision: 70cdb1ae3cadb3691c89b901b317b1a209318286
Assignee | ||
Comment 1•3 years ago
|
||
PR 26545 applied with additional changes from upstream: 01922bd5a5117ca87922358748ae6646e6031ab6
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e0dcc54088323cd68f29be6ed007ad462184a34
Assignee | ||
Comment 3•3 years ago
|
||
CI Results
Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 3 subtests
Status Summary
Firefox
OK : 1
FAIL: 3
Chrome
OK : 1
FAIL: 3
Safari
OK : 1
FAIL: 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/dom/abort/addEventListenerAbortController.tentative.html
Tests support for EventController to cancel event listeners in addEventListener.: FAIL (Chrome: FAIL, Safari: FAIL)
Tests support for EventController to cancel capture event listeners in addEventListener.: FAIL (Chrome: FAIL, Safari: FAIL)
Passing an AbortSignal to addEventListener options should allow removing a listener: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f793a272349c [wpt PR 26545] - Fix aborted AbortSignal in addEventListener, a=testonly https://hg.mozilla.org/integration/autoland/rev/4e346af1ea69 [wpt PR 26545] - Update wpt metadata, a=testonly
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f793a272349c
https://hg.mozilla.org/mozilla-central/rev/4e346af1ea69
Description
•