1677683 - Implement nsISmtpService.sendMailMessage in JS

Status: RESOLVED FIXED

(MailNews Core :: Networking: SMTP, task)

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1677683 - Part 1: Add SmtpModuleLoader to prepare for JS rewriting. r=mkmelin

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 1677683 - Part 2: Import emailjs-smtp-client to prepare for rewriting. r=mkmelin

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: Bug 1677683 - Part 3: Implement sendMailMessage with SmtpClient.jsm. r=mkmelin

Currently works when authentication is not required by the SMTP server. The focus is sendMailMessage, other functions in SmtpService.jsm should be considered incomplete.

Comment 4

[Magnus Melin [:mkmelin]]

Please mark the phab revision dependencies, so that they can be landed easily together.

Comment 5

[Ping Chen [:rnons] (away)]

(In reply to Magnus Melin [:mkmelin] from comment #4)

Please mark the phab revision dependencies, so that they can be landed easily together.

Done.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7f7603232e85
Part 1: Add SmtpModuleLoader to prepare for JS rewriting. r=mkmelin
https://hg.mozilla.org/comm-central/rev/03e5afc0f063
Part 2: Import emailjs-smtp-client to prepare for rewriting. r=mkmelin
https://hg.mozilla.org/comm-central/rev/7e0d70d11218
Part 3: Implement sendMailMessage with SmtpClient.jsm. r=mkmelin

Comment 7

[Ping Chen [:rnons] (away)]

Attachment: Bug 1677683 - Part 4: Handle authentication in sendMailMessage. r=mkmelin

Comment 8

[Ping Chen [:rnons] (away)]

Attachment: Bug 1677683 - Part 5: Add UTF-8 support and basic error handling to SmtpClient.jsm. r=mkmelin

Depends on D98041.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/493b61e2179d
Part 4: Handle authentication in sendMailMessage. r=mkmelin
https://hg.mozilla.org/comm-central/rev/d53854d7090e
Part 5: Add UTF-8 support and basic error handling to SmtpClient.jsm. r=mkmelin

Comment 10

[Günter Gersdorf]

• onStartSending of the user supplied listener is not called
  (because sendMailMessage() does not call OnStartRunningUrl of the deliveryListener)
• no meaningfull status is returned to onStopSending of the user supplied listener
  (seems that _actionStream() in SmtpClient.jsm does not return the SMTP server status)