Closed Bug 1677687 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26550 - [WebRTC] Fix getStats WPT flake caused by timestamp inprecision.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox85 fixed)

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox85 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26550 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26550
Details from upstream follow.

b'Henrik Bostr\xc3\xb6m <hbos@chromium.org>' wrote:

[WebRTC] Fix getStats WPT flake caused by timestamp inprecision.

Because of differences in precision when using timestamps from
performance.now() and timestamps from RTCStats.timestamp it was
possible for the test "RTCStats.timestamp increases with time passing"
to fail, e.g:

assert_less_than_equal: expected a number less than or equal to
505.65500000084285 but got 506

By flooring t0 and ceiling t1 we get a more broader view of the
maximumTimeElapsedBetweenGetStatsCallsMs.

This should fix the flake. If it doesn't, the issue may be related to
using different clocks or somehting, in which case we'll have to
revisit what this test can assert. For now, let's land and see if the
flake goes away.

TBR=philipp.hancke@googlemail.com

Bug: chromium:1093020
Change-Id: Ie8c8e379a244ca53ed207d20c5f4de68606d29d7
Reviewed-on: https://chromium-review.googlesource.com/2543923
WPT-Export-Revision: 5f86ba8ec26ff826aab25f2b9825ea48ad7335a1

PR 26550 applied with additional changes from upstream: ebcba650d3d41b33f9ca587c7b8416f1f154e6e5
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5696ff44674
[wpt PR 26550] - [WebRTC] Fix getStats WPT flake caused by timestamp inprecision., a=testonly

https://hg.mozilla.org/mozilla-central/rev/d5696ff44674

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.