1677735 - perma comm/mail/components/enterprisepolicies/tests/browser/browser_policy_block_about.js | and other NS_ERROR_BLOCKED_BY_POLICY [nsIWebNavigation.loadURI]" failures

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=322031248&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Ql3BQgBqTYOmi1CoDE3s6g/runs/0/artifacts/public/logs/live_backing.log

---

Caused by some mozilla-central change in https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=31d67eef91da183d26334f42e78ae41d9b37ff90```

Comment 1

[Magnus Melin [:mkmelin]]

Suspects bug 1675018 and bug 1585070 were backed out in the same push. Bug 1671983 perhaps.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1677735_blocked_by_policy.patch

This is one thing that needed porting from 1671983. But doesn't seem to fix things - just briefly checked locally. Sent it to try now: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0ed3440578b598bb5b3ea00275b74d5247bc3773

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e0ea3f0dc638
port bug 1671983 - Remove E10SUtils.shouldLoadURI. r=darktrojan
https://hg.mozilla.org/comm-central/rev/c2719f6fa5cc
Catch uncaught but expected NS_ERROR_BLOCKED_BY_POLICY in a test. rs=bustage-fix

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9188421 [details] [diff] [review]
bug1677735_blocked_by_policy.patch

Oops, I should review this before landing it. It doesn't fix the problem, but still needed doing.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1677735-about-pages-test.diff

Here's a patch that does fix the bug. I've already landed it.

I'm not entirely sure why this behaves differently on Firefox but it does. It seems to me the exception should throw for them too.
I think it has something to do with the relationship between their browser elements and gBrowser. The same behaviour occurs whether E10s is enabled or not.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9188480 [details] [diff] [review]
1677735-about-pages-test.diff

Review of attachment 9188480 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, I had the same question in bug 1672995 comment 3.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7f1183f577d4
Catch uncaught but expected NS_ERROR_BLOCKED_BY_POLICY in another test. rs=bustage-fix

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: bug1677735_about_devtools_blocked.patch

More syncing up

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9188512 [details] [diff] [review]
bug1677735_about_devtools_blocked.patch

Wrong patch

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: bug1677735_about_devtools_blocked.patch

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8d3857d43929
part 4 - more syncing up of the Firefox version of the test. r=darktrojan

Comment 12

[Intermittent Failures Robot]

2 failures in 4810 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform breakdown:

• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1677735&startday=2020-11-16&endday=2020-11-22&tree=all