Closed Bug 1677811 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 26554 - [fieldset] Fix fieldsets within flex by disabling simplified pass.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26554 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26554
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[fieldset] Fix fieldsets within flex by disabling simplified pass.

When flex did a 2-pass layout (once to determine the intrinsic size, and
a followup to shrink - and the block-size changed, we'd just perform
a simplified layout pass.

The fieldset layout algorithm "stretches" its content to its block-size
upfront. Due to this using the simplified layout pass resulted in an
incorrect layout, never correctly sizing the anonymous fieldset content.

This patch disables the simplified layout pass for fieldsets.

Bug: 1149714
Change-Id: I454a65363c019240dd4b30531009a13e8b596ea4
Reviewed-on: https://chromium-review.googlesource.com/2544755
WPT-Export-Revision: 2963c281840bb8f782728d563293e1bb738c1029

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/179595595cae [wpt PR 26554] - [fieldset] Fix fieldsets within flex by disabling simplified pass., a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.