1677852 - Show Firefox logo when pocket is not active, default on.

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Erica Wright [:ewright]]

We have a pref to show the Firefox logo on new tab. This will be turned on by default, but we will now only allow it to show the Firefox logo if Pocket is not enabled.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1677852 - Default on the Firefox logo on new tab, show when pocket is disabled.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03d90a1efb46
Default on the Firefox logo on new tab, show when pocket is disabled. r=Mardak

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/03d90a1efb46

Comment 4

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the Firefox logo is displayed when the "Recommended by Pocket" section is disabled on the latest Nightly build (85.0a1, BuildID 20201126093916) using Windows 10 x64, macOS 10.15.7, and Linux MX 4.19.

Comment 5

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: User Experience improvement for people without Pocket enabled.

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 9188426 [details]
Bug 1677852 - Default on the Firefox logo on new tab, show when pocket is disabled.

Beta/Release Uplift Approval Request

• User impact if declined: User Experience improvement for people without Pocket enabled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Disable the Recommended by Pocket section.

2. Load a newtab

expected: Should see a Firefox logo above search.

• List of other uplifts needed: Bug 1678740
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small code change.
• String changes made/needed: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9188426 [details]
Bug 1677852 - Default on the Firefox logo on new tab, show when pocket is disabled.

Approved for 84.0b7.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/485475e922cb

Comment 9

[Ryan VanderMeulen [:RyanVM]]

This seems like a nice to have but doesn't need to be tracked for the release.

Comment 10

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the Firefox logo is displayed when the "Recommended by Pocket" section is disabled on the latest Firefox Beta build (84.0b7, BuildID 20201201213706) using Windows 10 x64, macOS 10.15.7, and Linux MX 4.19.