Open Bug 1677882 Opened 5 years ago Updated 1 year ago

unreported memory from CookieJarSettings::Deserialize

Categories

(Core :: Permission Manager, defect, P3)

defect

Tracking

()

People

(Reporter: nika, Unassigned)

References

Details

Attachments

(1 file)

When looking at a DMD report for the parent process, I noticed a relatively large number of unreported heap allocations from this code due to CookieJarSettings::Deserialize, in this particular case with a short-lived session totalling around 2MB.

The majority of these objects were allocated as part of creating HTTP connections from LoadInfoArgsToLoadInfo in HttpChannelParent.

Given that a nsICookieJarSettings object exists in the parent process already attached to WindowGlobalParent, it may be possible to avoid this duplication by having the parent process look up the requesting window with WindowGlobalParent::GetByInnerWindowId(loadInfoArgs.innerWindowId()), rather than deserializing their own copy.

Either way, it would also be good to report these allocations with the memory reporter.

The severity field is not set for this bug.
:timhuang, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(tihuang)
Severity: -- → S3
Flags: needinfo?(tihuang)
Priority: -- → P2
Priority: P2 → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: