167795 - Change MRE to GRE

Status: VERIFIED FIXED

(Core Graveyard :: Installer: GRE, defect, P1)

Description

[Curt Patrick (gone)]

It has been agreed that Mozilla Runtime Environment should really be called
Gecko Runtime Environment.  I'm opening this as an installer bug because that is
where the changes are going to start, and because I don't actually know what is
the right component to use for MRE bugs.

So, for the installer we need to change all UI references, the registry paths
and the MreHome key.  When I get these changes checked then I'll reassign this
bug to Chak so he can sync up the MRE code itself.  And I guess GtkEmbed will
also need some modification to look in the right place in the registry?

Comment 1

[Chris Nelson]

since there are only two people I'm spamming at this point, I have to ask - is
this not a Mozilla project? What is the reasoning behind this?

Comment 2

[Curt Patrick (gone)]

Attachment: Patch 1.0

This patch makes the mre build deliver to dist\gre and dist\gre_app_support.

In addition I made changes under xpinstall\packages\ that involves renaming
directories and modifying files in those directories.  I don't know that a
patch is terribly useful in this case so I'll just describe the changes I made
there:

- Renamed pkgs-win-mre to pkgs-win-gre and search and replace "mre" in that
file.
- Renamed the directory "win-mre" to "win-gre"
- Did search and replace on "mre", "MRE" and "Mre" in the files makeall.pl and
config.it.
- Rename the file mre.jst to gre.jst and do a search and replace on the "mre"
strings in that file.

Comment 3

[Curt Patrick (gone)]

Aki, this is going to affect our nice new mre installer nightly builds.  Guess
you'd better put together a patch for you build process.  The essence is that
all files and directories that have "mre" in them need to be changed to have
"gre" in them, instead.  And then your patch and my patches will need to land
simultaneously.

Comment 4

[timeless]

> since there are only two people I'm spamming at this point,
hi. you spammed me. but I think you figured that out by now.

> I have to ask - is this not a Mozilla project?
> What is the reasoning behind this?
as for doing it, it makes me happy.

The MRE is a misnomer. it's in fact *not* a mozilla runtime environment. you
can't take a xul app and run it using the MRE. the current MRE is just
xpcom+necko+gecko (perhaps with a few other things). As such it is a *gecko*
runtime environment whose sole purpose in life is to allow people to embed gecko.

There is another runtime environment which was tentatively being called MXRE or
something silly like that. It's my hope that if *anything* is called MRE, it's that.

chak: re renaming files, please have leaf do cvs copies. then you can cvs remove
the original files or something and we won't lose cvsannotate information.

Comment 5

[Chak Nanga]

Comment on attachment 98651 [details] [diff] [review]
Patch 1.0

r=chak

Hi Curt : Could you please work with leaf to take care of the file
rename/remove details which timeless mentions above...thanks

This change will also have an impact on the nightly mre-win32.zip production.
It probably does'nt matter once we have the nightly GRE installers in
place(since we were planning on nuking the mre.zip builds once we have the real
gre installers anyway)

Comment 6

[Chak Nanga]

Upping priority on this one and adding topembeed+

We also need to get the nightly GRE installers going asap. We have a major
embedding customer (who's on a tight schedule) waiting on the nightly GRE builds
so their QA team can start testing it...thanks

Comment 7

[Aki Sasaki]

i believe we were not, in fact, getting rid of the mre zip file.

we'll have to get that renamed as well unless something's changed.

also, chak: have you looked at any of the nightly installer builds that have
been running the past week?

Comment 8

[Chak Nanga]

I think we decided to keep the nightly embed-win32.zip files but get rid of the
mre-win*.zip files once we have .exe MRE installers.

Sorry, i have'nt taken a look at the nightly MRE installers in the past couple
of days. I'll do that tonite(or  early tomorrrow) and post my comments....thanks

Comment 9

[Aki Sasaki]

Attachment: patch for build_verification.pl

build-verification patch.  includes changes for bug 163689 since that hasn't
been checked in yet.  basically changed all instances of mre to gre, and
commented out the gre zip file push.

Comment 10

[Curt Patrick (gone)]

Comment on attachment 98770 [details] [diff] [review]
patch for build_verification.pl

r=curt

Comment 11

[Curt Patrick (gone)]

Regarding the nightly builds, I have looked at a couple of them, but they
weren't really testable by Chak without the engine modifications which I checked
in yesterday when the tree unfroze.  Today's (last nights) builds look good.  If
we can get this naming change in place--and Chak needs to make some changes to
gre because of the name change also--we can have something testable.

Aki, can you go ahead and check your stuff in?  I'm going to get with Leaf about
checking my stuff in.

One other thing, slightly urelated but relevant:  I notice that the version
number for last night's mre installer was 1.2a.  When is that going to change to
1.2b?  Chak needs to change gre to match whatever you are using.

Comment 12

[Daniel (Leaf) Nunes]

Comment on attachment 98651 [details] [diff] [review]
Patch 1.0

sr=leaf

Comment 13

[Aki Sasaki]

right now the version is set to mozilla's version, which is hardcoded in several
places, but is mainly set in mozilla/config/milestone.txt

i'll check in when the trunk opens, but i can't update the build system until
all the name changes have been checked in as well or it'll break.

Comment 14

[Daniel (Leaf) Nunes]

Comment on attachment 98770 [details] [diff] [review]
patch for build_verification.pl


the makeall.pl calls for mfcembed and win_gre should be wrapped in a check for
whether we're doing embedding builds.

Also, why did you rearrange:
-    &Make_Mozilla_Packages; # creates mozilla-win32-installers
-
     &Make_Embedding_Package unless ($no_embedding);

+    &Make_Mozilla_Packages; # creates mozilla-win32-installers

Comment 15

[Aki Sasaki]

i rearranged those two because i need gre to be built before i make the
installer... which i put after the mozilla installers.  i'll check to see if
those calls would work if i put them in the Make_Embedding_Package function...
which would take care of the if/then embedding check.

Comment 16

[Aki Sasaki]

Attachment: moved gre installer stuff to Make_Embedding_Package()

this needs to be tested, but i believe it'll work.
i'll run a test build once all curt's changes are checked in.

Comment 17

[Aki Sasaki]

Attachment: fixing installer copy.

ran the test, and it worked.
two things:  the gre- copy commands were outside the if embedding/then block,
and i had commented out the latest-$milestone copy.

also, since i ran a nopull build, it reran the 8am build, so mre- named items
were still in the delivery dir.  none of them were touched, but i'm running a
clobber build right now to doublecheck.

Comment 18

[Aki Sasaki]

bleah, --no-commercial means that it doesn't create a new folder =P

anyway, you can see the latest installer stuff in latest-trunk and
2002-09-12-08-trunk (with the older mre stuff, but those weren't touched during
the build, just left over from this morning)

can someone take a look? tx

Comment 19

[Aki Sasaki]

=P
one of the changes broke the installer.
we're looking into it.

Comment 20

[Aki Sasaki]

the problem was an un-renamed mre.jst file.  fixed, and the installer in the
latest-trunk/ dir looks better.  if someone could take a look that'd be great.

Comment 21

[Chak Nanga]

I'm downloading the installer now from the linl below to test. Curt : Could you
pls do the same to make sure...thanks

ftp://ftp.mozilla.org/pub/mozilla/nightly/latest-trunk/gre-win32-installer.exe

Comment 22

[Chak Nanga]

Looking good...i downloaded the latest GRE installer and installed it. It
created the registry keys etc. as expected and copied the files to the specified
dir.

However, the only difference i noted was that the gfx2.dll and gfx2.xpt which
are in the GRE packaging manifests were not installed into the
gre\1.2b\components dir.

I remember seeing (on Bonsai) Alec merging the gfx stuff into a single dll.
Cc:ing Alec for his comments...thanks

Comment 23

[Chak Nanga]

Alec could you please comment on
http://bugzilla.mozilla.org/show_bug.cgi?id=167795#c22

Comment 24

[Aki Sasaki]

once we get signoff on the installer i'd like r/sr for the build-verification.pl
patch so i can check that in.

(the patched version is on the build system, however, so we'll keep getting gre
installer builds in the meantime)

Comment 25

[Curt Patrick (gone)]

Comment on attachment 98940 [details] [diff] [review]
fixing installer copy.

r=curt

Comment 26

[Curt Patrick (gone)]

Re comment #22:  For whatever reasons, it looks like gfx2.dll and gfx.xpt did
not get built.  They are not in the zip file either.  Unfortunately, for the
time being I'll need to know when files come and go (or developers are welcome
to modify the pkgs-gre-win file directly when they make changes).  Let me know
what needs to be done about these files.

Comment 27

[Alec Flett]

curt - sorry, I just nuked those files from the tree. they're no longer part of
the build. I updated the embedding package files, are there other files I need
to update now?

Comment 28

[Chak Nanga]

I think we're ok here...When we nuke a file the packaging manifests ignore if a
file is missing.

However, i still see references to gfx2.dll/xpt in a few files(though it does
not seem to hurt anything):

D:\mozilla_src\mozilla\embedding\config>grep gfx2 *
basebrowser-mac-cfm:Components:gfx2.shlb
basebrowser-mac-cfm:Components:gfx2.xpt
basebrowser-mac-cfmDebug:Components:gfx2Debug.shlb
basebrowser-mac-cfmDebug:Components:gfx2.xpt
basebrowser-mac-macho:; gfx2
basebrowser-mac-macho:components/libgfx2.dylib
basebrowser-mac-macho:components/gfx2.xpt
basebrowser-unix:components/libgfx2.so
basebrowser-unix:components/gfx2.xpt
basebrowser-win:components\gfx2.dll
basebrowser-win:components\gfx2.xpt

Comment 29

[Aki Sasaki]

my patch is checked in.

Comment 30

[Curt Patrick (gone)]

Everything is checked in.

Comment 31

[Charles Rosendahl]

verified