Closed Bug 1678054 Opened 4 years ago Closed 4 years ago

Enable bookmark toolbar upon bookmark import by default

Categories

(Firefox :: Bookmarks & History, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
85 Branch
Tracking Status
firefox84 --- verified
firefox85 --- verified

People

(Reporter: RT, Assigned: jaws)

References

Details

Attachments

(1 file)

Omnibus proved that the Shirley features improve user engagement while not regressing activation or retention:
https://docs.google.com/document/d/16JEiQ_8XSk3nBs9qcwMZC-76m4nttb1YRKwc6Xhf1xE/edit#heading=h.dywl2xu8cafc

We want to enable the Shirley features to all users. This bug in particular tracks enablement of the bookmark toolbar upon successful bookmark import action.

Acceptance criteria:

  • set browser.migrate.showBookmarksToolbarAfterMigration to true

The intention is to ship this with 84, an uplift will therefore be required.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → Bookmarks & History
Flags: needinfo?(jaws)
Flags: needinfo?(jaws)
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0c5f3119314 Enable showing the bookmarks toolbar after migration for all users. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

Can this be uplifted to 84 so we align all previous Shirley features to ship with 84 ?

Flags: needinfo?(jaws)

Comment on attachment 9188657 [details]
Bug 1678054 - Enable showing the bookmarks toolbar after migration for all users.

Beta/Release Uplift Approval Request

  • User impact if declined: Bookmarks toolbar doesn't show automatically even if bookmarks are imported there
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: This is just a pref flip so it shouldn't need additional testing. Testing happened in bug 1658541
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just a pref flip which we've already verified via Shirley
  • String changes made/needed: no
Attachment #9188657 - Flags: approval-mozilla-beta?
Flags: needinfo?(jaws)

Comment on attachment 9188657 [details]
Bug 1678054 - Enable showing the bookmarks toolbar after migration for all users.

Approved for 84.0b8.

Attachment #9188657 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Contact: daniel.cicas

Hello,

Verified on Fx 84.0b8 and 85.0a1 on Win 10, macOS 11 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: