Enable bookmark toolbar upon bookmark import by default
Categories
(Firefox :: Bookmarks & History, enhancement)
Tracking
()
People
(Reporter: RT, Assigned: jaws)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Omnibus proved that the Shirley features improve user engagement while not regressing activation or retention:
https://docs.google.com/document/d/16JEiQ_8XSk3nBs9qcwMZC-76m4nttb1YRKwc6Xhf1xE/edit#heading=h.dywl2xu8cafc
We want to enable the Shirley features to all users. This bug in particular tracks enablement of the bookmark toolbar upon successful bookmark import action.
Acceptance criteria:
- set browser.migrate.showBookmarksToolbarAfterMigration to true
Reporter | ||
Comment 1•4 years ago
|
||
The intention is to ship this with 84, an uplift will therefore be required.
Comment 2•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Reporter | ||
Comment 6•4 years ago
|
||
Can this be uplifted to 84 so we align all previous Shirley features to ship with 84 ?
Updated•4 years ago
|
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Comment on attachment 9188657 [details]
Bug 1678054 - Enable showing the bookmarks toolbar after migration for all users.
Beta/Release Uplift Approval Request
- User impact if declined: Bookmarks toolbar doesn't show automatically even if bookmarks are imported there
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce: This is just a pref flip so it shouldn't need additional testing. Testing happened in bug 1658541
- List of other uplifts needed: n/a
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just a pref flip which we've already verified via Shirley
- String changes made/needed: no
Updated•4 years ago
|
Comment 8•4 years ago
|
||
Comment on attachment 9188657 [details]
Bug 1678054 - Enable showing the bookmarks toolbar after migration for all users.
Approved for 84.0b8.
Comment 9•4 years ago
|
||
bugherder uplift |
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Hello,
Verified on Fx 84.0b8 and 85.0a1 on Win 10, macOS 11 and Ubuntu 18.04.
Description
•