1678061 - GfxInfo should detect both 10.16 and 11.0 as macOS Big Sur

Status: RESOLVED FIXED

(Core :: Graphics, task, P2)

Description

[Markus Stange [:mstange]]

The version number that Big Sur identifies as depends on the SDK. It can be 10.16 or 11.0. GfxInfo currently only detects 10.16 correctly.
Our Apple Silicon builds are compiled with the Big Sur SDK, so those builds will see 11.0.

I think we should rename the OperatingSystem enum value to OSX11_0 and add a path to OSXVersionToOperatingSystem that handles 11.0.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=96faa5dc52398c235ca2a086e1db161633650ddf

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

This impacts the downloadable blocklist, so it should be uplifted.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1678061 - Properly detect OSX 11.0 / 10.16 for blocklist purposes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8fc47f91b5a
Properly detect OSX 11.0 / 10.16 for blocklist purposes. r=jrmuizel

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c8fc47f91b5a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9188813 [details]
Bug 1678061 - Properly detect OSX 11.0 / 10.16 for blocklist purposes.

Beta/Release Uplift Approval Request

• User impact if declined: We won't be able to use the gfx blocklist with Big Sur / M1 devices.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only has a functional change on Big Sur / M1 devices. Big Sur or earlier / x86 is unaffected.
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9188813 [details]
Bug 1678061 - Properly detect OSX 11.0 / 10.16 for blocklist purposes.

Approved for 84.0b7.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0866c4a07f58