Clicking the local one-off heuristic result searches with the default engine
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: bugzilla, Assigned: adw)
References
Details
Attachments
(1 file)
STR
- Enter a search term.
- Press the up arrow a few times to select the Bookmarks one-off.
- Click the heuristic result.
Expected: We confirm bookmarks search mode.
Actual: We send the search term to the default search engine.
|
Assignee | |
Comment 1•4 years ago
|
||
Well that's no good. Maybe this just never worked?
|
Reporter | |
Comment 2•4 years ago
|
||
Yeah, I just ran mozregression back to bug 1658629 and it looks like clicking the heuristic never worked.
|
|
Assignee | |
Comment 3•4 years ago
|
||
We currently restyle URL heuristic results when a one-off is selected/search
mode is previewed, but afaict we should restyle all types. In the case of this
bug, the heuristic is a search result. I ended up rewriting most of
browser_oneOffs_heuristicRestyle.js to check various result types (URL, search,
and keyword) and both Alt-arrowing and non-Alt-arrowing down to the one-offs in
case that makes a difference.
This fixes part of bug 1678765, the part where we do the wrong thing when a
restyled keyword result is picked. It doesn't fix the visual part where the
action text is flush against the title text.
This also fixes a small error in UrlbarView._on_SelectedOneOffButtonChanged
where we were using result.payload.title when restyling heuristics, but
result.title is the correct property.
Depends on D97376
|
|
Assignee | |
Updated•3 years ago
|
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e246603a9e27 Restyle all heuristic result types when a one-off is selected/search mode is previewed. r=harry
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Description
•