1678291 - Misc mac build config cleanups

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1678291 - Don't set BINDGEN_CFLAGS in mac mozconfig.

This hasn't been necessary since bug 1526857.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1678291 - Default to use private frameworks from the SDK.

And don't set it via mozconfig. The default to /System/Library/PrivateFrameworks
may also not have matched the used SDK previously, so the new default it
better.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1678291 - Default to 11.0 as the macos target for aarch64.

There is no earlier SDK that supports it. It seems Xcode clang doesn't
care (maybe it defaults to 11.0 is MACOSX_DEPLOYMENT_TARGET is too low?),
but upstream clang does.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1e3d4009c17
Don't set BINDGEN_CFLAGS in mac mozconfig. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/5588b2b9a15e
Default to use private frameworks from the SDK. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/d2312de47d56
Default to 11.0 as the macos target for aarch64. r=firefox-build-system-reviewers,mhentges

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b1e3d4009c17
https://hg.mozilla.org/mozilla-central/rev/5588b2b9a15e
https://hg.mozilla.org/mozilla-central/rev/d2312de47d56

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 9188817 [details]
Bug 1678291 - Default to 11.0 as the macos target for aarch64.

Beta/Release Uplift Approval Request

• User impact if declined: Indirect dependency for bug 1678485
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): These patches are, in practice, no-ops for all builds, including Apple Silicon ones. They are only preparing things such that bug 1678154 doesn't break.
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9188815 [details]
Bug 1678291 - Don't set BINDGEN_CFLAGS in mac mozconfig.

Approved for 84.0b4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2884e586f703
https://hg.mozilla.org/releases/mozilla-beta/rev/36c29c0432e8
https://hg.mozilla.org/releases/mozilla-beta/rev/c4f2375b30e3