1678324 - [Linux] Firefox throws GLib-GObject-WARNING **: 12:04:41.268: invalid (NULL) pointer instance

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

Firefox throws:

GLib-GObject-WARNING **: 12:04:41.268: invalid (NULL) pointer instance
GLib-GObject-CRITICAL **: 12:04:41.268: g_signal_connect_data: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

Regression from Bug 1675908, gdk_screen_get_default() returns null.

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

Attachment: Bug 1678324 [Linux] Check GdkScreen before we use it, r?jhorak

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

Mike, can we test the somehow? Is there a testsuite which can catch errors on terminal?
Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e656ac10bf4
[Linux] Check GdkScreen before we use it, r=jhorak

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6e656ac10bf4

Comment 6

[Mike Hommey [:glandium]]

(In reply to Martin Stránský [:stransky] from comment #3)

Mike, can we test the somehow? Is there a testsuite which can catch errors on terminal?
Thanks.

Aren't at least the critical ones supposed to crash when they happen?

Comment 7

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

No, it crashes when G_DEBUG=fatal-criticals is set.

It's good to catch GLib-GObject-CRITICAL because it indicates problems in future (initialized variables/wrong types etc.) so it would be great to ensure that any new patch does not introduce it.