Closed Bug 1678386 Opened 4 years ago Closed 6 months ago

Remove nsXPTType backwards compatibility

Categories

(Core :: XPCOM, task, P3)

task

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

There's a section of nsXPTType that talks about "backwards compatibility". At least the TD_ALIAS_ stuff should be removable by replacing the uses, which appear to be in XPConnect. I'm not sure what role the two operator overloads might have.

There might be some other backwards compat in that file that can be easily removed. For instance, nsXPTMethodInfo::GetName() is unused.

I'm not sure what the "TD_ALIAS_ stuff" was, but currently this section consists entirely of 3 different "Get" methods that are trivial wrappers around other methods. The only tricky part here is that besides GetName() they have uses in the various non-T1 platform files in xpcom/reflect/xptcall, so you'll want to replace those at the same time even though it won't cause CI to fail.

Assignee: nobody → continuation

I did a simple find+sed kind of thing in the xpcom/reflect/xptcall/ and js/xpconnect/ directories, plus manual edits to xptinfo.h, to generate these patches.

Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/12db60492614 part 1 - Inline nsXPTMethodInfo::GetParamCount and nsXPTMethodInfo::GetName. r=xpcom-reviewers,emilio https://hg.mozilla.org/integration/autoland/rev/1bbbb1900de0 part 2 - Inline nsXPTMethodInfo::GetParam(). r=xpcom-reviewers,emilio
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
Blocks: 1897284
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: