Remove nsXPTType backwards compatibility
Categories
(Core :: XPCOM, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox128 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
There's a section of nsXPTType that talks about "backwards compatibility". At least the TD_ALIAS_ stuff should be removable by replacing the uses, which appear to be in XPConnect. I'm not sure what role the two operator overloads might have.
Assignee | ||
Comment 1•4 years ago
|
||
There might be some other backwards compat in that file that can be easily removed. For instance, nsXPTMethodInfo::GetName() is unused.
Assignee | ||
Comment 2•6 months ago
|
||
I'm not sure what the "TD_ALIAS_ stuff" was, but currently this section consists entirely of 3 different "Get" methods that are trivial wrappers around other methods. The only tricky part here is that besides GetName() they have uses in the various non-T1 platform files in xpcom/reflect/xptcall, so you'll want to replace those at the same time even though it won't cause CI to fail.
Assignee | ||
Updated•6 months ago
|
Assignee | ||
Comment 3•6 months ago
|
||
GetName has no uses.
Assignee | ||
Comment 4•6 months ago
|
||
Assignee | ||
Comment 5•6 months ago
|
||
I did a simple find+sed kind of thing in the xpcom/reflect/xptcall/ and js/xpconnect/ directories, plus manual edits to xptinfo.h, to generate these patches.
Comment 7•6 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/12db60492614
https://hg.mozilla.org/mozilla-central/rev/1bbbb1900de0
Description
•