1678485 - Enable PGO on arm64 mac builds

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1678485 - Enable PGO on arm64 mac builds.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aa6dbc8826d
Enable PGO on arm64 mac builds. r=firefox-build-system-reviewers,andi,rstewart

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 9189133 [details]
Bug 1678485 - Enable PGO on arm64 mac builds.

Beta/Release Uplift Approval Request

• User impact if declined: Better performance for Apple Silicon builds
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: 1678291 1677023 1677022 1677020 1678154
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): There's the possibility that this triggers some miscompilation.
  But all the patches involved are no-ops for the other builds.
  Also one side effect is that bug 1678154 makes the Apple Silicon builds faster and not rely on a small pool of worker.
• String changes made/needed:

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9189133 [details]
Bug 1678485 - Enable PGO on arm64 mac builds.

This isn't normally the kind of change I'd take in a Beta, but given that it's a new platform shipping for the first time to a small group of real-world users and there's likely a lot of interest in Firefox' performance on Apple Silicon, it seems like the risk is justified here. Approved for 84.0b4.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8741f4b59298

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7aa6dbc8826d