1678555 - Switching between contact name formats (first-last, last-first and display) does not update the view

Status: VERIFIED FIXED

(Thunderbird :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

Selecting a different format from the menu sets a preference, but nothing is watching the preference to update the view, so it doesn't change until you select a different address book or reopen the window.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1678555 - Update the address book view when the name format changes. r?mkmelin

This also remembers the preference value, which should provide a tiny performance improvement.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fee59305845f
Update the address book view when the name format changes. r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c0619f163948
follow-up - Fix linting mistake. rs=linting DONTBUILD

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9189109 [details]
Bug 1678555 - Update the address book view when the name format changes. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1633620
User impact if declined: menu option in address book window does nothing until reopened
Testing completed (on c-c, etc.): on c-c a few days
Risk to taking this patch (and alternatives if risky): not risky

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9189109 [details]
Bug 1678555 - Update the address book view when the name format changes. r?mkmelin

[Triage Comment]
Approved for beta

Comment 6

[Dave Miller [:justdave]]

Thunderbird 84.0b3
https://hg.mozilla.org/releases/comm-beta/rev/311aa3e3feae
https://hg.mozilla.org/releases/comm-beta/rev/c2d39e24bc72

Comment 7

[WaltS48 [:walts48]]

Looks good in my test of the 84.0b3 release candidate on Ubuntu 18.04 LTS.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9189109 [details]
Bug 1678555 - Update the address book view when the name format changes. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.6.0:
https://hg.mozilla.org/releases/comm-esr78/rev/d7332ed7f626
https://hg.mozilla.org/releases/comm-esr78/rev/5356cea5643e

Comment 10

[WaltS48 [:walts48]]

Verified in testing of the Thunderbird 78.6.0 release candidate on Windows 10.