1678583 - Cleanup FOG FFI bridge & IDL layer

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Jan-Erik Rediger [:janerik]]

We don't use the same types consistently, e.g. we should use AUTF8String in the IDL definition and pass through references to some type of nsString to Rust to use them there instead of C-style char* "strings".
Plus some other style cleanups.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1678583 - Use a proper bool type in return. r?chutten!

Depends on D97596

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1678583 - Clean up FFI bridge & IDL layer. r?chutten!

This touches multiple parts at once, including:

• Remove usage of this-> in C++ code
• Use nsACString across the FFI (no need for ffi-support anymore)
• Use AUTF8String in the IDL definition, so we can pass it on unmodified.

Depends on D99033

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1678583 - Apply same cleanup to boolean metric. r?chutten!

Depends on D99034

Comment 4

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1678583 - Provide same optional API on datetime & timespan. r?chutten!

Depends on D99035

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e40c4b34ec7
Use a proper bool type in return. r=chutten
https://hg.mozilla.org/integration/autoland/rev/7346565f35b4
Clean up FFI bridge & IDL layer. r=chutten
https://hg.mozilla.org/integration/autoland/rev/555eb48642be
Apply same cleanup to boolean metric. r=chutten
https://hg.mozilla.org/integration/autoland/rev/1e26d2cecfe7
Provide same optional API on datetime & timespan.  r=chutten

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4be67b807b6
Use a proper bool type in return. r=chutten
https://hg.mozilla.org/integration/autoland/rev/20d3051ed77d
Clean up FFI bridge & IDL layer. r=chutten
https://hg.mozilla.org/integration/autoland/rev/6948d67082a3
Apply same cleanup to boolean metric. r=chutten
https://hg.mozilla.org/integration/autoland/rev/8aea353c110c
Provide same optional API on datetime & timespan.  r=chutten

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d4be67b807b6
https://hg.mozilla.org/mozilla-central/rev/20d3051ed77d
https://hg.mozilla.org/mozilla-central/rev/6948d67082a3
https://hg.mozilla.org/mozilla-central/rev/8aea353c110c