Closed Bug 167861 Opened 22 years ago Closed 22 years ago

PK11_GetModInfo fails to set error code

Categories

(NSS :: Libraries, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nelson, Assigned: rrelyea)

Details

Attachments

(1 file, 1 obsolete file)

PK11_GetModInfo returns SECFailure in two places. 
It does not call PORT_SetError or equivalent in either place.

In one case, it has just returned from a PKCS#11 call.  It should translate
the PKCS#11 error to a SEC error before returning SECFailure.
Assigned the bug to Bob.
Assignee: wtc → relyea
Priority: -- → P2
Target Milestone: --- → 3.6
Comment on attachment 100418 [details] [diff] [review]
Set Error after failed PKCS #11 call.

>+    if (crv != SECSuccess) {
>+	PORT_SetError(PK11_MapError(crv));
>+    }

I think this should say "if (crv != CKR_OK) { ...".
Attachment #100418 - Flags: needs-work+
good catch. here's the corrected patch.
Attachment #100418 - Attachment is obsolete: true
Comment on attachment 100660 [details] [diff] [review]
patch with Wan-Teh's comments

r=wtc.
Attachment #100660 - Flags: review+
checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: