Closed
Bug 1678613
Opened 4 years ago
Closed 3 years ago
Promise previewer not using property descriptors broke VariablesView
Categories
(DevTools :: Console, defect)
Tracking
(firefox-esr78 unaffected, firefox83 unaffected, firefox84 unaffected, firefox85 fixed)
RESOLVED
FIXED
85 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox83 | --- | unaffected |
| firefox84 | --- | unaffected |
| firefox85 | --- | fixed |
People
(Reporter: Oriol, Assigned: Oriol)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
In bug 1676476, when creating the preview for a promise, I forgot that the values in ownProperties are supposed to be property descriptors.
Reps seems fine with raw values, but VariablesView is now broken:
var { require, loader } = ChromeUtils.import("resource://devtools/shared/Loader.jsm");
loader.lazyImporter(this, "VariablesView", "resource://devtools/client/storage/VariablesView.jsm");
var current = {class: "Promise", preview: {ownProperties: {"<state>": "pending"}}};
VariablesView.stringifiers.byObjectKind.Object(current, {concise: false});
// Promise {<state>: undefined}
var shouldBe = {class: "Promise", preview: {ownProperties: {"<state>": {value: "pending"}}}};
VariablesView.stringifiers.byObjectKind.Object(shouldBe, {concise: false});
// Promise {<state>: "pending"}
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Comment 2•3 years ago
|
||
Set release status flags based on info from the regressing bug 1676476
status-firefox83:
--- → unaffected
status-firefox84:
--- → unaffected
status-firefox85:
--- → affected
status-firefox-esr78:
--- → unaffected
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa29b0520668 Use property descriptors in promise previewers. r=nchevobbe
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•