1678766 - Add license header to SVG files that are missing one

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, task)

Description

[Rob Lemley [:rjl]]

There are a number of SVG files missing license headers:

comm/calendar/base/themes/common/calendar-itip-icons.svg
comm/calendar/base/themes/common/calendar-occurrence.svg
comm/calendar/base/themes/common/icons/newevent.svg
comm/calendar/base/themes/common/widgets/images/drag-center.svg
comm/mail/components/cloudfile/wetransfer/images/logo.svg
comm/mail/components/enterprisepolicies/content/policies-active.svg
comm/mail/components/enterprisepolicies/content/policies-documentation.svg
comm/mail/components/enterprisepolicies/content/policies-error.svg
comm/mail/themes/addons/dark/icon.svg
comm/mail/themes/addons/light/icon.svg
comm/mail/themes/shared/mail/icons/cert-error.svg
comm/mail/themes/shared/openpgp/attach-active-18.svg
comm/mail/themes/shared/openpgp/attach-disabled-18.svg
comm/mail/themes/shared/openpgp/attach-inactive-18.svg
comm/mail/themes/shared/openpgp/decrypt-active-18.svg
comm/mail/themes/shared/openpgp/decrypt-inactive-18.svg
comm/mail/themes/shared/openpgp/encrypt-active-18.svg
comm/mail/themes/shared/openpgp/encrypt-disabled-18.svg
comm/mail/themes/shared/openpgp/encrypt-inactive-18.svg
comm/mail/themes/shared/openpgp/headerProtected-18.svg
comm/mail/themes/shared/openpgp/headerUnprotected-18.svg
comm/mail/themes/shared/openpgp/ok-sign.svg
comm/mail/themes/shared/openpgp/password-error.svg
comm/mail/themes/shared/openpgp/sign-active-18.svg
comm/mail/themes/shared/openpgp/sign-disabled-18.svg
comm/mail/themes/shared/openpgp/sign-inactive-18.svg

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1678766-SVG-license-header.patch

When I was on it I optimised some SVGs.

For the WeTransfer icon I'm not sure if adding a Mozilla License header is okay. I don't know if this icon comes from WeTransfer itself. This should investigated.

The OpnPGP files seems to be not used but still packaged to the executables. I only added the license without anything other. Someone should look at this folder and clean-up what isn't needed.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9189350 [details] [diff] [review]
1678766-SVG-license-header.patch

Review of attachment 9189350 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!

Comment 3

[Rob Lemley [:rjl]]

This is sill lacking those few files Richard pointed out, right? Who is checking on those? Let's not close this bug until they're all done and the check can be turned on for these files.

Comment 4

[Richard Marti (:Paenglab)]

None should lacking the header.

Geoff, what about the WeTransfer icon? I've added a Mozilla license header. Is this okay or should Rob add an exception for that file?

Comment 5

[Geoff Lankow (:darktrojan)]

I don't think it should have a Mozilla header as it's not our property. I'm not sure what our agreement with WeTransfer says about use of their logo, but it's probably best left without a header.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1678766-SVG-license-header.patch

Patch without the WeTransfer icon.

Rob, when you enable the linting you need to add a exception.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cdea27c3fabd
Add license header to SVG files that are missing one. r=aleca

Comment 8

[Rob Lemley [:rjl]]

Attachment: enable_svg_lint.patch

I'm going to go ahead and land this since its just enabling the check for SVGs and I fixed one more file that snuck in since Richard posted his patch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2daad155803e
Enable license linting SVG files. rs=linting