1678844 - Japanese IME would not work properly on https://wowma.jp/

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Alice0775 White]

Reproducible: always with MS-IME, ATOK

Steps to reproduce:

1. Open https://wowma.jp/
2. Focus search field on top of the page
3. IME ON
4. Type some word
   e.g pasokonn

Actual Results:
Composing string appears as ｐああｓｓおおここｎｎ and so on.
And these text are committed automatically.

Expected Results:
Composing string should appear as ぱそこん.
And these text should stay under construction.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fdd37e7f4f5ba2b3def6581a26b67cdf09238872&tochange=7b96efde9ee17f2c79245b7a6047fd686d7f4621

Comment 1

[Edgar Chen [:edgar]]

Hi Makoto, would you mind taking a look? This seems like a regression of bug 1658948.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1678844 - Don't call SetInputContext on keyboard event. r=masayuki

This is another regression by bug 1658948 and Windows only.

When user script calls element.focus() during keyboard event, our TSF client
implementation commits composition string.

It is unnecessary to call SetInputContext when real keybaord event is fired.

Because,

• If keybaord event is fired, virtual keybaord is already shown
• We don't open virtual keyboard when physical keyboard is available on Android

So I shouldn't call SetInputContext on user interaction by keyboard.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84ee1d563994
Don't call SetInputContext on keyboard event. r=masayuki

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/84ee1d563994