167890 - opening the move/copy menu slow for imap accounts with lots of folders

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

filter UI:  slow to bring filter list dialog (build filter after the fact 
picker) for certain imap accounts.

bienvenu thinks:  "I see why bringing up the filter list dialog is so slow. 
it's opening all the db's.  presumably, to get flags or something.
it should be using the panacea.dat, though."

this is new UI, from my landing for #161002

Comment 1

[David :Bienvenu]

I'll take a look at this.

Comment 2

[David :Bienvenu]

the problem is that the filter dialog is using CanFileMessages to populate the
folders we can apply folders to - I don't think that's correct, since whether we
can file a message into a folder or not doesn't really determine if we can run
filters on it. I suspect CanFileMessages is used more in the sense of read-only,
adn that's probably roughly correct.

But the ultimate problem is that we're not caching the imap folder acl in
panacea.dat, which we really should be, if it's going to be asked for en masse
like that. That would also speed up the move/copy menu's, since they have this
same problem.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: popping like ozone.

Comment 4

[(not reading, please use [e-mail] instead)]

dmb says:  we need to caching the imap folder acl in panacea.dat

this fix fixes the message list dialog problem, by properly using noselect, 
which is what I really wanted in the first place.  I was just being stupid.

dmb says:  noselect is fast, because it's a folder flag, which is stored in the 
panacea.dat  (no select is not acl)

leaving bug open.

Comment 5

[(not reading, please use [e-mail] instead)]

patch checked in.

Comment 6

[laurel]

Amen. My main account's hierarchy in the File/Move/Copy menu has always been a
bear. 

Comment 7

[David :Bienvenu]

I still need to fix this for the drag drop case - when you drag a message over
the folder pane, it opens the dbs of all the folders you drag over.

Comment 8

[David :Bienvenu]

I fixed this a while ago.