Closed Bug 1678917 Opened 4 years ago Closed 3 years ago

Make glxtest more best effort to detect information

Categories

(Core :: Graphics, defect, P3)

Desktop
Linux
defect

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

If glxtest encounters a failure, it gives up immediately and doesn't give any information it has gathered up to that point. It would be nice to separate the errors from gathering information such as the vendor/device IDs if possible. Even if GLX and EGL are broken, we still might be able to get some sense from the PCI detection. This could be more useful from a telemetry perspective as well.

Blocks: wr-linux

If we encounter a single error in glxtest, we typically bail immediately
with one liner message. This patch makes it put more effort into
returning what information it is able to, as well as the current error
messages. If certain errors are correlated to specific devices, it would
be useful if we had the information to make the connection.

Andrew, do you have more concerns or can we land this one? I'd love to have this in place for bug 1588904

Flags: needinfo?(aosmond)
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f3024fb74fb
Make glxtest fail more gracefully. r=rmader

Nope, I was just away last week and let it slide :).

Flags: needinfo?(aosmond)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Regressions: 1680515
Blocks: 1680512
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: