1678986 - The “Login Item” view wrongly remains displayed after removing all logins if a selected login was in Edit mode

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: wronglyLoginItemView.gif

[Affected versions]:

• Firefox Nightly 85.0a1 (Build ID: 20201122213806)

[Affected Platforms]:

• Mac 10.15.6
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest version of Firefox Nightly installed.
• Have a Firefox profile with at least one login saved.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to the "about:logins" page.
3. Select a saved login and click on the “Edit” button.
4. Click on the Menu button.
5. Select the “Remove All Logins…” option.
6. Tick the "Yes, remove these logins." checkbox and click on the “Remove All” button from the dialog.
7. Observe the Login Item area.

[Expected result]:

• All logins are successfully removed and the "No FxA sync" state of the about:logins page is displayed.

[Actual result]:

• All logins are successfully removed and the Login Item view of a login that was in Edit mode remains displayed.

[Notes]:

• This issue is not reproducible after removing the last saved login manually.
• The "No FxA sync" state of the about:logins page is displayed after the page refresh.
• Attached a screen recording with the issue.

Comment 1

[Tim Giles [:tgiles]]

Attachment: Bug 1678986 - Reset login-item edit view mode if user opens 'Remove All Logins' dialog. r=sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca6dd23e0b1b
Reset login-item edit view mode if user opens 'Remove All Logins' dialog. r=sfoster

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ca6dd23e0b1b

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 85.0a1 (Build ID: 20201206213246) on Windows 10 x64, Ubuntu 20.04 and Mac 10.15.7.

• The "No FxA sync" state of the about:logins page is correctly displayed after removing all saved logins while a selected login was in Edit mode.

While verifying this I have encountered the following issue which was introduced by this fix: Bug 1681042.

• Considering this I’ll mark this issue as Verified fixed.