1679050 - Context menu has an empty section in newtab page

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Screen+Shot+2020-11-23+at+7.56.58+PM.png

On the latest MacOS Nightly, when I right click in the newtab page, there is an empty section in the context menu.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

I can reproduce this in safe mode with addons disabled.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b2da4b644dd901a46d80e36d184a2222066a8780&tochange=73181c2aa30976f579385fe2f266db99ec2e6314

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59216bd2227a
Backed out changeset 73181c2aa309 (bug 1455479) for having too many false positives. r=backout,a=NarcisB

Comment 4

[Emilio Cobos Álvarez (:emilio)]

So... this is fixable, but there's the underlying issue of "why is the paste button there to begin with, and why does it do nothing".

Turns out that react adds a global paste listener, which doesn't in fact handle pastes, so we enable the button, but it does nothing and looks broken :(

I can repro similar behavior on facebook / google / a bunch of other important sites. So I think we should just back out bug 1455479 and wontfix it. Oh well.

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/59216bd2227a

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (85.0a1 Build ID - 20201123214551) installed on Windows 10 x64, Linux Mint 20 x64, and Mac 10.15. Now I can confirm that the empty section is no longer displayed in the New Tab context menu.