1679136 - [Firefox Alpenglow] Separators in the Bookmarks toolbar are almost invisible

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Oana Botisan, Desktop QA]

Attachment: imgpsh_fullsize_anim.png

Affected versions

• Firefox 84.0b4
• Firefox 85.0a1

Affected platforms

• Ubuntu 18.04 x64
• Windows 10 x64
• macOS 10.15

Preconditions

• Make sure that the Firefox Alpenglow is enabled.

Steps to reproduce

1. Open Bookmarks Toolbar
2. Add a few separators via context menu ( right-click on Bookmarks Toolbar and click on "New Separator").

Expected result

• The separator is visible.

Actual result

• Separator is almost invisible.

Regression range

• If it's a regression, I will try to find it asap.

Suggested severity

• S3

Comment 1

[Oana Botisan, Desktop QA]

• Last good: 2020-10-20 (20201020145547)
• First bad: 2020-10-21 (20201021095128)
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5b5ffbe4add97c98003026e0d9a730302161b646&tochange=d8861d51b01e9489672f998648d67662a60a8b3a
• Potential regressor: Bug 1665442

Comment 2

[:Gijs (he/him)]

I'm on a data-limited mobile connection until next Tuesday, and I don't have a build handy that has both alpenglow and the pre-patch appearance. Can you take a screenshot of what the separators used to look like, ie what's the expected look of the separators in the light/dark alpenglow theme? And what does the hamburger menu separator look like in those cases?

Comment 3

[Oana Botisan, Desktop QA]

Attachment: dark alpenglow.png

Comment 4

[Oana Botisan, Desktop QA]

Attachment: Light Alpenglow.png

Comment 5

[Oana Botisan, Desktop QA]

The hamburger menu separators or any other menu on the url bar don't seem to be changed. They are the same on the latest version as they were on the older unaffected version.

Comment 6

[:Gijs (he/him)]

(In reply to Oana Botisan, Desktop Release QA from comment #5)

The hamburger menu separators or any other menu on the url bar don't seem to be changed. They are the same on the latest version as they were on the older unaffected version.

Sure, but the new separators now look the same as the one next to the hamburger, which was always very very faint / invisible (also in the "unaffected" version).

I'll see if I can find any designs / ideas around what these should look like.

Comment 7

[Oana Botisan, Desktop QA]

Attachment: Screenshot_30.png

The separators from the hamburger menu are a bit faded, but they are distinguishable. The bookmark separator are invisible.

Comment 8

[:Gijs (he/him)]

(In reply to Oana Botisan, Desktop Release QA from comment #7)

The separators from the hamburger menu are a bit faded, but they are distinguishable. The bookmark separator are invisible.

I don't mean the ones inside the menu, I mean the vertical line to the left of the hamburger button itself, which is just as invisible as the bookmarks ones...

Comment 9

[Oana Botisan, Desktop QA]

I don't mean the ones inside the menu, I mean the vertical line to the left of the hamburger button itself, which is just as invisible as the bookmarks ones...

In that case, that one is affected too. I looked inside the menu bar. Sorry for the confusion.

Comment 11

[:Gijs (he/him)]

Attachment: Bug 1679136 - fix separator colour in alpenglow light and dark, r?jaws

Comment 12

[:Gijs (he/him)]

Comment on attachment 9190894 [details]
Bug 1679136 - fix separator colour in alpenglow light and dark, r?jaws

Beta/Release Uplift Approval Request

• User impact if declined: Separators are invisible
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment #0
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Super low risk. Just changing some CSS variables for the alpenglow theme only, and incrementing the version number so this change takes effect.
• String changes made/needed: nope

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/568324188993
fix separator colour in alpenglow light and dark, r=jaws

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/568324188993

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9190894 [details]
Bug 1679136 - fix separator colour in alpenglow light and dark, r?jaws

Approved for 84.0b8.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4636445f0fac

Comment 17

[Oana Botisan, Desktop QA]

I verified the fix using Latest Nightly 85.0a1 and Firefox 84.0b8 on Windows 10 x64 (both with dark and light theme), Ubuntu 18.04 x64 and macOS 11.0.1. The issue is not reproducing anymore.
On Ubuntu and macOS even though the line is visible is still lighter than the ones that are on Windows. Is that intended? Or it's the difference on the settings from my monitors?

Comment 18

[:Gijs (he/him)]

(In reply to Oana Botisan, Desktop Release QA from comment #17)

I verified the fix using Latest Nightly 85.0a1 and Firefox 84.0b8 on Windows 10 x64 (both with dark and light theme), Ubuntu 18.04 x64 and macOS 11.0.1. The issue is not reproducing anymore.

Thanks for the quick verification.

On Ubuntu and macOS even though the line is visible is still lighter than the ones that are on Windows. Is that intended? Or it's the difference on the settings from my monitors?

The exact colour will depend on the background - it's semi-transparent. The semi-transparent colour specified is the same cross-platform, so for separators in exactly the same place there shouldn't be a difference across platforms. Happy to take a look at a specific screenshot if you think there's still something off compared to Windows?

Comment 19

[Oana Botisan, Desktop QA]

I was working on the image and just realized they are exactly the same colour. I think the difference I saw was because of my monitor settings (my main monitor has really low brightness). Sorry for the confusion.
I will mark this issue as verified fixed.