Closed
Bug 1679253
Opened 4 years ago
Closed 3 years ago
remove <deck> from chat.inc.xhtml
Categories
(Thunderbird :: Instant Messaging, task)
Thunderbird
Instant Messaging
Tracking
(thunderbird_esr78 wontfix)
RESOLVED
FIXED
85 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | wontfix |
People
(Reporter: mkmelin, Assigned: khushil324)
References
Details
Attachments
(1 file)
|
3.44 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Remove <deck> from chat.inc.xhtml: https://searchfox.org/comm-central/rev/f8c11a36225bbe5e145f1a9a0a3801428e265715/mail/components/preferences/chat.inc.xhtml#175-185
https://searchfox.org/comm-central/search?q=previewDeck&path=
Apparently has a fixed height. A second deck child added dynamically. These could just be set hidden/unhidden one at a time
Of course the whole preview is borked at the moment on trunk...
|
Assignee | |
Comment 1•4 years ago
|
||
Attachment #9189758 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•4 years ago
|
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•3 years ago
|
||
Comment on attachment 9189758 [details] [diff] [review] Bug-1679253_remove-deck-chat-inc-xhtml-0.patch Review of attachment 9189758 [details] [diff] [review]: ----------------------------------------------------------------- Yeah should do it. Of course, it's rather questionable that chat should support it's own theme to begin with :/ It's not like we have different themes for other parts of the application either.
Attachment #9189758 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Updated•3 years ago
|
Keywords: checkin-needed-tb
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/66258638d95a
remove <deck> from chat.inc.xhtml. r=mkmelin
|
||
Updated•3 years ago
|
Target Milestone: --- → 85 Branch
|
|
Reporter | |
Updated•3 years ago
|
status-thunderbird_esr78:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•