1679257 - remove <deck> from messenger.xhtml

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

Remove <deck> from https://searchfox.org/comm-central/rev/f8c11a36225bbe5e145f1a9a0a3801428e265715/mail/base/content/messenger.xhtml#708

https://searchfox.org/comm-central/rev/f8c11a36225bbe5e145f1a9a0a3801428e265715/mail/base/content/mailTabs.js#728

Needs some investigation how all the different 3pane (or not) view modes interact. But other than that, likely the children we have can just be set hidden/not as appropriate instead of setting a selectedIndex for the decks.

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679257_de-deck-messenger-xhtml-0.patch

Comment 2

[Khushil Mistry [:khushil324]]

Comment on attachment 9190106 [details] [diff] [review]
Bug-1679257_de-deck-messenger-xhtml-0.patch

There are some test failures. Re-submitting in a while.

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679257_de-deck-messenger-xhtml-1.patch

https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=b8256d5015b85b64d08772803a19b6eb2efc78fc

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9190301 [details] [diff] [review]
Bug-1679257_de-deck-messenger-xhtml-1.patch

Review of attachment 9190301 [details] [diff] [review]:
-----------------------------------------------------------------

At least the caps/tests/unit/test_site_origin.js test seems broken by this

But seems ok otherwise.

::: mail/base/content/mailTabs.js
@@ +674,3 @@
>     */
>    _setPaneStates(aLegalStates, aVisibleStates) {
>      // The display deck hosts both the thread pane and account central.

maybe box instead of deck

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679257_de-deck-messenger-xhtml-2.patch

I have sent it for another try-run, the same patch and now it looks good: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=465c51807f51741928941dc8f74c69e625070ccc

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/70ab6aa7bfc7
remove <deck> from messenger.xhtml. r=mkmelin