1679264 - remove <deck> from imAccounts.xhtml

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, task)

Description

[Magnus Melin [:mkmelin]]

The <deck> usage in https://searchfox.org/comm-central/rev/f8c11a36225bbe5e145f1a9a0a3801428e265715/mail/components/preferences/chat.inc.xhtml#175-185 should be removed.

We simply shouldn't show that pane at all if no accounts are set up. Instead, we can add the "Add new account" to the main view, like next to the "Conversations will be shown here". Maybe out of scope for this bug, but it would be better for that view to show the account setup hub instead, with chat accounts selected, once we have that in a page.

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679264_de-deck-imAccounts-xhtml-0.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9189730 [details] [diff] [review]
Bug-1679264_de-deck-imAccounts-xhtml-0.patch

Review of attachment 9189730 [details] [diff] [review]:
-----------------------------------------------------------------

What about comment 0? Maybe show a notification bar instead if no accounts? 
This patch fixes the no-deck, but still leaves the extra complications.

Let's have aleca review

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679264_de-deck-imAccounts-xhtml-1.patch

Comment 4

[Alessandro Castellani [:aleca]]

We simply shouldn't show that pane at all if no accounts are set up.

That dialog is not accessible if no account is currently set.
I think the pane variation is necessary only for the scenario in which a user opens the dialog, then clicks on properties and deleted the IM accounts.
Now the dialog is still opened even if no accounts are present.

Instead, we can add the "Add new account" to the main view, like next to the "Conversations will be shown here".

I think we already do that if I'm not missing something.
If no accounts are configured there's a (not very intuitive) Get Started button in the main pane.

I think we shouldn't spend too much time on this dialog as it would make more sense to drop it entirely since the IM accounts properties are all managed in a tab. This whole area should be heavily rebuilt, so I think a simple deck removal here is good enough.

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9189940 [details] [diff] [review]
Bug-1679264_de-deck-imAccounts-xhtml-1.patch

Review of attachment 9189940 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me as I explained in the comment before.
Of course Magnus you can cancel my review if you think we should do something more here.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/299cdd699762
remove <deck> from imAccounts.xhtml. r=aleca