1679265 - remove <deck> from importDialog.xhtml

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

Remove <deck> from https://searchfox.org/comm-central/rev/f8c11a36225bbe5e145f1a9a0a3801428e265715/mailnews/import/content/importDialog.xhtml#43,84

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679265_de-deck-importDialog-xhtml-0.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9189842 [details] [diff] [review]
Bug-1679265_de-deck-importDialog-xhtml-0.patch

Review of attachment 9189842 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/import/content/importDialog.js
@@ +147,5 @@
> +  let stateBox = document.getElementById("stateBox");
> +  for (let element of stateBox.children) {
> +    element.hidden = true;
> +  }
> +  stateBox.children[index].hidden = false;

I'd think this gives a potential small flickering. Better to loop with 
for (let i = 0 ; i < stateBox.children.length; i++) {
  stateBox.children[i].hidden = (i == index);
}

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679265_de-deck-importDialog-xhtml-1.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9189924 [details] [diff] [review]
Bug-1679265_de-deck-importDialog-xhtml-1.patch

Review of attachment 9189924 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dcb6687561af
remove <deck> from importDialog.xhtml. r=mkmelin