remove <deck> from subscribe.xhtml
Categories
(Thunderbird :: General, task)
Tracking
(thunderbird_esr78 wontfix, thunderbird84 wontfix)
People
(Reporter: mkmelin, Assigned: khushil324)
References
Details
Attachments
(2 files, 5 obsolete files)
12.70 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
1.18 KB,
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
Remove <deck> from subscribe.xhtml: https://searchfox.org/comm-central/rev/f8c11a36225bbe5e145f1a9a0a3801428e265715/mailnews/base/content/subscribe.xhtml#82
Two children of fixed size, can just instead show/hide the one we need as appropriate.
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
Assignee | ||
Comment 4•4 years ago
|
||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
Comment 7•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/95215a32c31f
Remove the XUL <deck> element from the subscribe.xhtml dialog. r=aleca
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 9•4 years ago
|
||
Looks like this has broken comm/mail/test/browser/subscribe/browser_newsFilter.js
./mach test comm/mail/test/browser/subscribe/browser_newsFilter.js
Marionette TRACE Received observer notification toplevel-window-ready
0:08.97 GECKO(52978) JavaScript error: resource://testing-common/mozmill/SubscribeWindowHelpers.jsm, line 71: TypeError: can't access property "getColumnFor", tree.columns is null
0:08.98 INFO Console message: [JavaScript Error: "TypeError: can't access property "getColumnFor", tree.columns is null" {file: "resource://testing-common/mozmill/SubscribeWindowHelpers.jsm" line: 71}]
check_newsgroup_displayed@resource://testing-common/mozmill/SubscribeWindowHelpers.jsm:71:17
filter_test_helper/<@chrome://mochitests/content/browser/comm/mail/test/browser/subscribe/browser_newsFilter.js:54:36
waitFor@resource://testing-common/mozmill/utils.jsm:155:45
filter_test_helper@chrome://mochitests/content/browser/comm/mail/test/browser/subscribe/browser_newsFilter.js:53:9
callback@resource://testing-common/mozmill/SubscribeWindowHelpers.jsm:41:14
startTest@resource://testing-common/mozmill/WindowHelpers.jsm:343:16
WindowWatcher_notify@resource://testing-common/mozmill/WindowHelpers.jsm:380:9
Subscribe@chrome://messenger/content/mailCommands.js:367:10
MsgSubscribe@chrome://messenger/content/mailWindowOverlay.js:2178:14
oncommand@chrome://messenger/content/messenger.xhtml:1:1
MozMillController.prototype.click@resource://testing-common/mozmill/controller.jsm:391:13
wrapperFunc@resource://testing-common/mozmill/WindowHelpers.jsm:1343:32
open_subscribe_window_from_context_menu@resource://testing-common/mozmill/SubscribeWindowHelpers.jsm:44:6
test_subscribe_newsgroup_filter@chrome://mochitests/content/browser/comm/mail/test/browser/subscribe/browser_newsFilter.js:36:42
Tester_execTest/<@chrome://mochikit/content/browser-test.js:1069:34
Tester_execTest@chrome://mochikit/content/browser-test.js:1109:11
nextTest/<@chrome://mochikit/content/browser-test.js:932:14
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1037:23
Assignee | ||
Comment 10•4 years ago
|
||
Need to wait for a few miliseconds between toggling two elements.
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=52adcbb3d76604ebb6d2a885571226dc2d2ec0e2
Assignee | ||
Comment 11•4 years ago
|
||
Reporter | ||
Comment 12•4 years ago
|
||
Reporter | ||
Comment 13•4 years ago
|
||
Reporter | ||
Comment 14•4 years ago
|
||
Linted.
Assignee | ||
Comment 15•4 years ago
|
||
Comment 16•4 years ago
|
||
Description
•