1679269 - remove <deck> from removeAccount.xhtml

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, task)

Description

[Magnus Melin [:mkmelin]]

remove <deck> from removeAccount.xhtml: https://searchfox.org/comm-central/rev/f8c11a36225bbe5e145f1a9a0a3801428e265715/mailnews/base/prefs/content/removeAccount.xhtml#30,74

Fixed height, we can just show/hide needed child as appropriate. Though I think it would be nicer to redesign this so that the progress bar and status are shown below, and the selections are just disabled once the process starts.

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679269_de-deck-removeAccount-xhtml-0.patch

I have done the de-deck part.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9190023 [details] [diff] [review]
Bug-1679269_de-deck-removeAccount-xhtml-0.patch

Review of attachment 9190023 [details] [diff] [review]:
-----------------------------------------------------------------

This UI is very strange, I think a follow up bug to improve it will be necessary.

There's an issue we should solve here tho.
Then I click on the More Info button, the subdialog doesn't properly resize and the buttons are cut off.

::: mailnews/base/prefs/content/removeAccount.xhtml
@@ +27,4 @@
>    <stringbundle id="bundle_removeAccount"
>                  src="chrome://messenger/locale/removeAccount.properties"/>
>    <script src="chrome://messenger/content/removeAccount.js"/>
> +  <hbox flex="1">

this hbox container is not necessary anymore.

@@ +27,5 @@
>    <stringbundle id="bundle_removeAccount"
>                  src="chrome://messenger/locale/removeAccount.properties"/>
>    <script src="chrome://messenger/content/removeAccount.js"/>
> +  <hbox flex="1">
> +    <vbox id="removeAccountSection" flex="1">

this flex=1 is not necessary

@@ +70,3 @@
>        </vbox>
>      </vbox>
> +    <vbox id="confirmationSection" align="center" hidden="true" flex="1">

also this flex=1 is not necessary

@@ +73,1 @@
>        <spacer flex="1"/>

also the flex=1 for these spacers is not necessary since we're inside a vbox and all the elements are naturally expanded to their full width as they're stacked.

@@ +73,2 @@
>        <spacer flex="1"/>
> +      <hbox>

this hbox container is not necessary.

Comment 3

[Khushil Mistry [:khushil324]]

(In reply to Alessandro Castellani (:aleca) from comment #2)

   </vbox>
 </vbox>
<vbox id="confirmationSection" align="center" hidden="true" flex="1">

also this flex=1 is not necessary

Now, we need <vbox id="confirmationSection" align="center" pack="center" flex="1" hidden="true"> to align vertically the children element else labels or the progress bar will be align top rather than center.

Comment 4

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679269_de-deck-removeAccount-xhtml-1.patch

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9190084 [details] [diff] [review]
Bug-1679269_de-deck-removeAccount-xhtml-1.patch

Review of attachment 9190084 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, with a small fix.

::: mailnews/base/prefs/content/removeAccount.js
@@ +98,4 @@
>      document.getElementById("localAccount").collapsed = false;
>    }
>  
> +  window.resizeBy(0, removeDataPossibility.getBoundingClientRect().height);

Here we can use `parent.gSubDialog._topDialog.resizeDialog();`
This is a built-in method of the subdialog, and since we're opening  the remove account only as a pref subdialog, we will always have access to those elements.

With this we can avoid the selector and fetching the bounding client rect.

Comment 6

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679269_de-deck-removeAccount-xhtml-2.patch

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bdf75ba0f26b
remove <deck> XUL element from removeAccount.xhtml dialog. r=aleca