1679489 - view_source.editor.external stopped working

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Alex]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

Firefox developer edition 84.0b5 (64-bit) on Windows

Set view_source.editor.external to true
Set view_source.editor.path to C:\Program Files (x86)\Notepad++\notepad++.exe
Open a site and hit CTRL-U

Actual results:

The source opened in a tab

Expected results:

The source should have opened in the external editor (notepad++) like it used to in previous versions.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]: The feature is broken

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e12b84262d8b4a09cd91f094436dc5edda03c39d&tochange=e93201b4e9087963e449099650d63bdb3dcbb2c2

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1679489 - Fixing the issue that cookieJarSettings cannot be fetched from the browser. r?dimi!

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1679489 - Add test cases to check the cookieJarSettings of the browser object. r?dimi!

Depends on D98053

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b69ddb28638
Fixing the issue that cookieJarSettings cannot be fetched from the browser. r=dimi
https://hg.mozilla.org/integration/autoland/rev/ea06934f0213
Add test cases to check the cookieJarSettings of the browser object. r=dimi

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4b69ddb28638
https://hg.mozilla.org/mozilla-central/rev/ea06934f0213

Comment 6

[Tim Huang[:timhuang]]

Comment on attachment 9189962 [details]
Bug 1679489 - Fixing the issue that cookieJarSettings cannot be fetched from the browser. r?dimi!

Beta/Release Uplift Approval Request

• User impact if declined: The view_source.editor.external would break
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just a one-line change. And it doesn't change the behavior.
• String changes made/needed: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9189962 [details]
Bug 1679489 - Fixing the issue that cookieJarSettings cannot be fetched from the browser. r?dimi!

Approved for 84.0b7. Thanks for including tests.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c4518f737147
https://hg.mozilla.org/releases/mozilla-beta/rev/7934887bcdef