16795 - [DOGFOOD] Cursor keys don't do anything within Editor window

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Eli Goldberg]

* TITLE/SUMMARY
Cursor keys don't do anything within Editor window (or text edit fields)

* STEPS TO REPRODUCE
0) Launch Apprunner
1) Open the Editor (currently, you'll have to select "Edit Blank Page" from File
| New)
2) Type in some text, or load a text file
3) Place the caret within the document, and press a few arrow keys.

* RESULT
 - What happened

The caret doesn't move. Page Up/Page Down doesn't work either. Neither do these
keys work within a form text field (e.g. on www.netscape.com's search field)

 - What was expected

Behavior equivalent to Win32/Mac OS build.

* REGRESSION

 - Occurs On
        Linux Apprunner (10.18.99 9:00 build)

 - Doesn't Occur On
        Win32 Apprunner (10.19.99 8:00 build [NT 4, Service Pack 5])
        Mac OS  Apprunner (10.18.99 9:00 build)




* CONFIGURATIONS TESTED

- [Mac] Beige Power Mac G3 (266 MHz PowerPC 750), 96 MB RAM (VM on; 1 MB of VM
used), 1024x768 (Thousands of Colors), Mac OS 8.6

- [Win32] Vectra VL (233 MHz P2), 96 MB RAM, 800x600 (True Color), NT 4.0 SP5.

- [Linux] Vectra VL (266 MHz P2), 96 MB RAM. Red Hat Linux 6.0 (GNOME).

Comment 1

[cpratt]

I'm going to need this for dogfood. This means (for example) you can't do
anything with the keyboard in the Location: control.

Comment 2

[Akkana Peck]

This is probably related to some of the changes that happened shortly after the
key event branch landing.  I'm looking into it.  Pavlov, do you know anything
about arrow key event changes?

Comment 3

[Akkana Peck]

Found it: gtk events' length is zero for these key events, so we shouldn't check
length before generating a KeyPress.  (I remember fixing that once before,
somehow it crept back in.)  Patch attached, will try to get code review and
check in tomorrow (anyone on the cc list want to review the patch?  Pavlov?  It
also fixes meta keys).

Comment 4

[Akkana Peck]

Attachment: Patch to fix the problem

Comment 5

[Akkana Peck]

Attachment: New patch for gtk event handler (ignore the old one)

Comment 6

[Stuart Parmenter]

good job akkana!  you can check this patch in as soon as you would like.

this fixes arrow keys

page up and page down give me:

onkeypress = EditorMoveUpPage( true, false )
oncommand =
JavaScript Error: ReferenceError: EditorMoveUpPage is not defined

onkeypress = EditorMoveDownPage( true, false )
oncommand =
JavaScript Error: ReferenceError: EditorMoveDownPage is not defined

but they generate the right error for the right key so i think they are doing
the right thing :)

Comment 7

[Akkana Peck]

Fixed.

Comment 8

[Eli Goldberg]

*** Bug 16870 has been marked as a duplicate of this bug. ***

Comment 9

[sujay]

verified in 10/21 build.