Closed Bug 1679542 Opened 5 years ago Closed 5 years ago

Get rid of *QUOTA_NAMESPACE* macros and stop including QuotaCommon.h everywhere

Categories

(Core :: Storage: Quota Manager, task)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: sg, Assigned: sg)

Details

Attachments

(1 file)

QuotaCommon.h is included in other exported header files and pulls in a lot of other dependencies, which are only required internally in the quota manager and its clients.

This would call for splitting the header up. Maybe this should still be done for logical reasons, but the only reason for several of these includes are the BEGIN_QUOTA_NAMESPACE and END_QUOTA_NAMESPACE macros, which have become obsolete since we have C++17 nested namespace declarations.

These macros are now removed, and the now unused include directives for QuotaCommon.h are removed along.

Status: NEW → ASSIGNED
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d9303f2d336 Get rid of *QUOTA_NAMESPACE* macros and stop including QuotaCommon.h everywhere. r=dom-workers-and-storage-reviewers,ttung
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: