Closed Bug 1679559 Opened 3 years ago Closed 3 years ago

Port bug 1679463: Replace :not(foo):not(bar) with :not(foo,bar)

Categories

(Thunderbird :: Theme, task)

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
85 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

:not() has supported selector lists since bug 933562, so :not(X):not(Y) can now just be :not(X,Y) for simplicity.

Attached patch 1679559-replace-not-not.patch (obsolete) — Splinter Review

Port of https://hg.mozilla.org/mozilla-central/rev/04bb3866f539.

I met no space after , like we did on other places, :is for example.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9190017 - Flags: review?(alessandro)
Comment on attachment 9190017 [details] [diff] [review]
1679559-replace-not-not.patch

Review of attachment 9190017 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

::: mail/components/im/content/chat.css
@@ +45,5 @@
>  .status-container {
>    width: 15em;
>  }
>  
> +#statusMessageLabel:not([statusType="offline"],[disabled]), .statusMessageInput[editable] {

Shouldn't .statusMessageInput[editable] be on its own line?
Attachment #9190017 - Flags: review?(alessandro) → review+

(In reply to Alessandro Castellani (:aleca) from comment #2)

Comment on attachment 9190017 [details] [diff] [review]
1679559-replace-not-not.patch

Review of attachment 9190017 [details] [diff] [review]:

Looks good, thanks!

::: mail/components/im/content/chat.css
@@ +45,5 @@

.status-container {
width: 15em;
}

+#statusMessageLabel:not([statusType="offline"],[disabled]), .statusMessageInput[editable] {

Shouldn't .statusMessageInput[editable] be on its own line?

Yes, also the following rule was the same.

Attachment #9190017 - Attachment is obsolete: true
Attachment #9190024 - Flags: review+
Target Milestone: --- → 85 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/e0095ee79f03
Port bug 1679463: Replace :not(foo):not(bar) with :not(foo,bar). r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: