1679696 - Comments in PDF viewer sometimes not shown (are streakthroughs in same line the problem?)

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect)

Description

[AnonymesKind]

Attachment: Comparison between wrong behaviour (upper picture) and right behaviour (lower picture).

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

Opened a PDF Document that had comments (annotations for added text and strikethroughs for deleted text). The program by which the document was edited is not known.

Actual results:

Hoovering over a strikethrough (displayed as text with red strikethrough) resulted in a reddish pop-up with the name of the commenter. Hoovering over some annotations (displayed as yellow highlighter) caused a yellowish pop-up with the content of the annotations and the name of the commenter, but hoovering over other annotations, which had a strikethrough in the same line as the annotations, caused a reddish pop-up with just the name of the commenter to appear, so that the content of the annotations doesn't show up. But this didn't happen to every comment with a strikethrough in the same line, but just with some of them.

Expected results:

The expected result would be that all annotations would show a yellowish pop-up after hoovering over them, which would contain the text added by the commenter.
This was tested in Adobe Acrobat Reader DC, where it worked correctly, so it's probably not a problem of the PDF document itself.

The attached picture contains 2 photos (because the pop-ups don't show in screenshots) of one annotation that doesn't work (no text shows up, and red colour of strikethrough) and one that works correctly despite of the strikethrough on the same line.

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Calixte Denizet (:calixte)]

:AnonymesKind, could you attach the pdf file ?

Comment 3

[AnonymesKind]

(In reply to Calixte Denizet (:calixte) from comment #2)

:AnonymesKind, could you attach the pdf file ?

:calixte, is it possible to send it to you privately? I can cut one page of this pdf out, but the headline of the pdf-page contains personal information from the author (who isn't me, my friend discovered this bug first), and he may be not too glad if I put it here into the public and accessable by search-engines.

In Adobe the removal of private information is only available for pay-accounts, and free online-tools remove also the comments from the file. Just putting a black rectangle above doesn't help of course, because the text underneath remains.

Comment 4

[Calixte Denizet (:calixte)]

:AnonymesKind, sure you can send it privately and I'll try to create a minimal test case.

Comment 5

[Calixte Denizet (:calixte)]

Fix in review:
https://github.com/mozilla/pdf.js/pull/12673

Comment 6

[AnonymesKind]

Thank you very much! I looked at it although I hardly understand javascript :D
Glad to see how the development of Firefox works. How can I see in GitHub when this code change will appear in Nightly or main Firefox? No emergency, just out of interest.

Comment 7

[AnonymesKind]

Nevermind, it works in the new Nigthly-Edition :D