1679733 - Crash in [@ nsLayoutUtils::HasAnimationOfPropertySet]

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect, P3)

Description

[Gabriele Svelto [:gsvelto]]

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/6679f10a-4171-4be8-aff7-9bdfc0201127

Reason: EXCEPTION_STACK_OVERFLOW

Top 10 frames of crashing thread:

0 xul.dll static nsLayoutUtils::HasAnimationOfPropertySet layout/base/nsLayoutUtils.cpp:240
1 xul.dll static nsLayoutUtils::HasAnimationOfTransformAndMotionPath layout/base/nsLayoutUtils.cpp:280
2 xul.dll nsIFrame::HasPerspective const layout/generic/nsIFrame.cpp:1825
3 xul.dll nsDisplayTransform::GetLayerState layout/painting/nsDisplayList.cpp:8224
4 xul.dll RequiredLayerStateForChildren layout/painting/nsDisplayList.cpp:5634
5 xul.dll nsDisplayTransform::GetLayerState layout/painting/nsDisplayList.cpp:8239
6 xul.dll RequiredLayerStateForChildren layout/painting/nsDisplayList.cpp:5634
7 xul.dll nsDisplayTransform::GetLayerState layout/painting/nsDisplayList.cpp:8239
8 xul.dll RequiredLayerStateForChildren layout/painting/nsDisplayList.cpp:5634
9 xul.dll nsDisplayTransform::GetLayerState layout/painting/nsDisplayList.cpp:8239

This appears to be a stack overflow while building display lists. It started on nightly so disregard the crashes that aren't on nightly because they are unrelated. Users have reported that the crash is often rejected by our crash machinery because it's too large (10+ MiB) so the volume here might as well be larger.

Comment 1

[Gabriele Svelto [:gsvelto]]

Will, I've been sent a few crash reports that users were unable to submit. The minidump was ~14 MiB in size, I vaguely remember that we bumped up the maximum size of the crash reports that Socorro accepts so I was a bit puzzled that this was rejected. Maybe we didn't increase the size enough? This crash is a stack overflow so it's rather important that it can be reported correctly.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Gabriele: We did increase the max payload size to 25mb (bug #1648387). Maybe the 14mb minidump + whatever else is in the payload exceeds our max size. I created bug #1679787 to increase it again.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Gabriele Svelto [:gsvelto] from comment #0)

Maybe Fission related. (DOMFissionEnabled=1)

I don't think this crash is Fission related, even though one of the (two) 85.0a1 crash reports had Fission enabled.

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson [:cpeterson] from comment #3)

(In reply to Gabriele Svelto [:gsvelto] from comment #0)

Maybe Fission related. (DOMFissionEnabled=1)

I don't think this crash is Fission related, even though one of the (two) 85.0a1 crash reports had Fission enabled.

Crash volume is very low and we have no reports from 88 or 89 yet.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.