1679780 - remove <deck> from calendar-creation.xhtml

Status: RESOLVED FIXED

(Calendar :: General, task)

Comment 1

[Khushil Mistry [:khushil324]]

Remove <deck> from https://searchfox.org/comm-central/rev/bfc7644683950de390d29602ccf43c7fc358491e/calendar/base/content/dialogs/calendar-creation.xhtml#39

It has five children. These we can show/hide as needed.

Comment 2

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679780_de-deck-calendar-creation-xhtml-0.patch

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9190309 [details] [diff] [review]
Bug-1679780_de-deck-calendar-creation-xhtml-0.patch

Review of attachment 9190309 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/content/dialogs/calendar-creation.js
@@ +293,1 @@
>   * @param {string} id          The id of the panel node to select.

Nit: update this comment to respect the format we're using (eg. @param {string} id - The id of the panel node to select.)

@@ +293,5 @@
>   * @param {string} id          The id of the panel node to select.
>   */
>  function selectPanel(id) {
> +  for (let element of document.getElementById("calendar-creation-dialog").children) {
> +    element.hidden = element.getAttribute("id") != id;

element.id != id;

@@ +371,5 @@
>      return;
>    }
>  
>    let disabled = false;
> +  switch (selectedPanel.getAttribute("id")) {

selectedPanel.id

Comment 4

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679780_de-deck-calendar-creation-xhtml-1.patch

Comment 5

[Magnus Melin [:mkmelin]]

For calendar, maybe have Geoff sign off as well

Comment 6

[Khushil Mistry [:khushil324]]

https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=9c207970e8f0d1f9ae98fdc4b629a40f6172c460

Comment 7

[Khushil Mistry [:khushil324]]

Should we check in the patch now?

Comment 8

[Magnus Melin [:mkmelin]]

Please have Geoff take a look as well.

Comment 9

[Khushil Mistry [:khushil324]]

Sure.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b2c5ca90c712
remove <deck> XUL element from calendar-creation.xhtml dialog. r=aleca,darktrojan

Comment 11

[Ping Chen [:rnons] (away)]

Attachment: 1679780-panel-height.patch

Fix the panel height so that content is not clipped.

Comment 12

[Ping Chen [:rnons] (away)]

Attachment: Screenshot from 2021-02-05 10-31-40.png

It looks like this without the fix

Comment 13

[Alessandro Castellani [:aleca]]

Comment on attachment 9201299 [details] [diff] [review]
1679780-panel-height.patch

Review of attachment 9201299 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc87eccf2a12
Fix panel-select-calendars height in calendar-creation dialog. r=aleca