1679788 - event summary dialog: ugly black border around the x

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Magnus Melin [:mkmelin]]

In the event summary dialog, when you have an event you have accepted, on top there's a

"You have accepted this invitation" [x]

The x to close now has an ugly black border around it when the window has focus.
Pretty sure this is a regression.

Comment 1

[Richard Marti (:Paenglab)]

I can't test this as I have no calendar that supports invitations.

Comment 2

[Magnus Melin [:mkmelin]]

Google calendar? Let me know if you want an invite sent.

Comment 3

[Richard Marti (:Paenglab)]

Ah, found it now. Thought it's in the message pane notification.

Comment 4

[Richard Marti (:Paenglab)]

This is the focus-ring, try pressing TAB. Somehow the initial focus is set to the notification close button.

Comment 5

[Magnus Melin [:mkmelin]]

That seems to be it yes. Still ugly though.

Comment 6

[Alessandro Castellani [:aleca]]

Indeed, this looks pretty bad, also on dark or LTW theme variation as it makes the notification bar look cut.
This is the focus ring coming from toolkit.

I think we should consider:

• Having our own focus ring style, like the 1px dashed line, which is still visible but less "in your face" (carefully considering visibility is important)
• Controlling the initial focus in the invitation summary, which shouldn't be on the close notification icon, but rather a more "useful" default location.

Comment 7

[Richard Marti (:Paenglab)]

I'll tackle the close button focus ring style in the summary dialog in bug 1680755.

Comment 8

[Magnus Melin [:mkmelin]]

This is now better, thanks Richard!