1679828 - remove <deck> from calendar-today-pane.inc.xhtml

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Khushil Mistry [:khushil324]]

Remove <deck> from https://searchfox.org/comm-central/rev/1fa5ebe1384434e904b33bb7de8f0a3d6e8bfdc5/calendar/lightning/content/calendar-today-pane.inc.xhtml#82

Children that can be set hidden/not as appropriate instead of setting selectedIndex on the deck.

Comment 1

[Khushil Mistry [:khushil324]]

Here, there is no use of the <deck> element. We can directly use a single <label> element instead. Submitting a patch in a while.

Comment 2

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679828_de-deck-calendar-today-pane-inc-xhtml-0.patch

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9190346 [details] [diff] [review]
Bug-1679828_de-deck-calendar-today-pane-inc-xhtml-0.patch

Review of attachment 9190346 [details] [diff] [review]:
-----------------------------------------------------------------

Good stuff and elegant solution.

Comment 4

[Khushil Mistry [:khushil324]]

https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=9c207970e8f0d1f9ae98fdc4b629a40f6172c460

Comment 5

[Khushil Mistry [:khushil324]]

Should we check in the patch now?

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9190346 [details] [diff] [review]
Bug-1679828_de-deck-calendar-today-pane-inc-xhtml-0.patch

Review of attachment 9190346 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/lightning/content/calendar-today-pane.inc.xhtml
@@ +84,1 @@
>                  <spacer id="weekspacer" flex="1"/>

IMO you can get rid of this spacer and give the flex="1" to the label.

Comment 7

[Khushil Mistry [:khushil324]]

Attachment: Bug-1679828_de-deck-calendar-today-pane-inc-xhtml-1.patch

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/df77d633742e
remove <deck> XUL element from calendar-today-pane.inc.xhtml. r=aleca,darktrojan