1679843 - Remove last use of @menuPanelButtonWidth@

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[Markus Stange [:mstange]]

There's one remaining use of the menuPanelButtonWidth define, for customize mode. We can replace this instance with -moz-box-flex and simplify the code.

https://searchfox.org/mozilla-central/rev/168c45a7acc44e9904cfd4eebcb9eb080e05699c/browser/themes/shared/customizableui/panelUI.inc.css#1449-1453

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1679843 - Use -moz-box-flex instead of min-width for combined buttons in the overflow menu in customize mode. r=Gijs

This makes it more adaptable to toolbaritem-combined-buttons with varying
numbers of buttons.
I'm planning to introduce a usage of toolbaritem-combined-buttons with only two
buttons in bug 1650835 (a regular button and a dropmarker button), and the
dropmarker button is hidden when the item is shown in the panel, so we end up
with just one visible button, and the max-width was making it look silly.

This was the last reference to menuPanelButtonWidth, so we can remove the hack
was introduced in bug 963365. The max-width was needed originally because we had
a three-column layout in the panel, and each button could have wrapping text, so
-moz-box-flex wouldn't have enforced a fixed column width.
But the three-column layout is gone, and our current toolbaritem-combined-buttons
(zoom + edit buttons) don't require wrapping text.

Depends on D98213

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5642ac1f250f
Use -moz-box-flex instead of min-width for combined buttons in the overflow menu in customize mode. r=Gijs

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5642ac1f250f