1679901 - Use the same account creation code in both types of WebExtension test

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, task)

Description

[Geoff Lankow (:darktrojan)]

We account creation functions in mail/components/extensions/test/browser/head.js and mail/components/extensions/test/xpcshell/head.js, but they are different (apart from the fact that the xpcshell tests deal with IMAP and mochitests do not).

Fixing this so we can create other accounts in mochitest.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1679901 - Use the same account creation code in both types of WebExtension test.

I thought I could just copy from the XPCShell head file to the Mochitest head file, but we need
the ability to create a local mail account for one test, so I've added that to both files.

Comment 2

[Magnus Melin [:mkmelin]]

Do we want it backported?

Comment 3

[John Bieling (:TbSync)]

As I would like to backport bug 1658132 which depends on this, I would say yes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/da1974132f49
Use the same account creation code in both types of WebExtension test. r=TbSync

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9190425 [details]
Bug 1679901 - Use the same account creation code in both types of WebExtension test.

[Approval Request Comment]
Test only, wanted for at least bug 1658132

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9190425 [details]
Bug 1679901 - Use the same account creation code in both types of WebExtension test.

[Triage Comment]
Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.6.1:
https://hg.mozilla.org/releases/comm-esr78/rev/f74d4338a126