Block frame should recompute its float and overflow container children's overflow under vertical-rl writing-mode
Categories
(Core :: Layout, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox85 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(5 files)
See the attached testcase.
I believe the block frame should recompute its float and overflow container children's overflow area after those children's position are moved. Otherwise the children's overflow may contribute to the block frame's overflow area, resulting in an unnecessary scrollbar if the block is in a scroll container.
Assignee | ||
Comment 1•3 years ago
|
||
This is likely to be the root cause of the backout on Android in bug 1674774 comment 10 because Android enables dom.meta-viewport.enabled
. If <html>
has writing-mode:vertical-rl
, there may be an extra scrollbar on root element if the overflow area is wrong.
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D98515
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D98516
Assignee | ||
Comment 5•3 years ago
|
||
Depends on D98517
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d8c3b7dfc06c Part 1 - Remove unused nsReflowStatus parameter in nsBlockFrame::ReflowPushedFloats(). r=emilio https://hg.mozilla.org/integration/autoland/rev/f153b932ed5e Part 2 - Recompute float children's overflow area after moving them in vertical-rl writing-mode. r=layout-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/a6d31e726b0b Part 3 - Recompute overflow container children's overflow area after moving them in vertical-rl writing-mode. r=layout-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/ddc258aa88d4 Part 4 - Remove workaround for flex item fragmentation reftests for Android. r=layout-reviewers,emilio,jfkthame
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26789 for changes under testing/web-platform/tests
Comment 8•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d8c3b7dfc06c
https://hg.mozilla.org/mozilla-central/rev/f153b932ed5e
https://hg.mozilla.org/mozilla-central/rev/a6d31e726b0b
https://hg.mozilla.org/mozilla-central/rev/ddc258aa88d4
Upstream PR merged by moz-wptsync-bot
Description
•