1679997 - Add cssOrigin to declarative contentScripts API (manifest.json, scripting, contentScripts)

Status: RESOLVED FIXED

(WebExtensions :: Compatibility, enhancement, P3)

Description

[erosman [:erosman]]

Similar to tabs.insertCSS(), an option to set cssOrigin would be beneficial. e.g.

browser.contentScripts.register({
  matches: [hosts],
  css: [{code, cssOrigin: "user"}],
  runAt: "document_idle"
});

Comment 1

[Tomislav Jovanovic :zombie]

This sounds reasonable, and should be fairly easy since we already support it for tabs.executeScript. I'm expecting just a matter of adding a field to register options:
https://searchfox.org/mozilla-central/rev/1843375acb/toolkit/components/extensions/schemas/content_scripts.json#10
maybe forwarding it along the line in implementation starting from:
https://searchfox.org/mozilla-central/rev/1843375acb/toolkit/components/extensions/parent/ext-contentScripts.js#148
and adding a test probably around here:
https://searchfox.org/mozilla-central/rev/1843375acb/toolkit/components/extensions/test/xpcshell/test_ext_contentScripts_register.js

The guide to getting started is at https://wiki.mozilla.org/WebExtensions/Contribution_Onramp.

Comment 2

[gero]

Hi,

since I'd like to practice testing in this scope, it's great if I can fix this bug. Could I?

Comment 3

[Falguni Islam]

Hello, I am new to contributing to Bugzilla can you assigned me to this issue so that I can learn to fix these bugs and also suggest to me how can Is start working on this bug to fix it

Comment 4

[Tomislav Jovanovic :zombie]

Sorry Falguni, but gero has asked first.

(In reply to gero from comment #2)

since I'd like to practice testing in this scope, it's great if I can fix this bug. Could I?

Sure, I assigned the bug to you. Take a look at comment 1 for details on getting started, and feel free to ask questions (use "request information" below the comment box here).

Comment 5

[Tomislav Jovanovic :zombie]

Hey Gero, how is it going with this bug? If you have an issue, feel free to ask.

Otherwise, we'd like to assign this bug to someone else.

Comment 6

[gero]

Sry for being disappeared, feel free to assign it to the other guy.

Comment 7

[Ankit Jain]

HI there,
I would like to work on this issue, I have set development environment, can you please guide me solving this.
I set mozilla-central development environment, am I on right way for this issue?

Comment 8

[Leslie]

Hi my name is Leslie and I am an Outreachy applicant. Can I work on this bug?

Comment 10

[Rob Wu [:robwu]]

These days, the scripting API is the primary API to register content scripts and styles. Therefore I'm adjusting the title to reflect the full scope of changes.

There is consensus across browsers to support the feature, at https://github.com/w3c/webextensions/issues/414

Comment 11

[Tomislav Jovanovic :zombie]

(In reply to Rob Wu [:robwu] from comment #10)

These days, the scripting API is the primary API to register content scripts and styles. Therefore I'm adjusting the title to reflect the full scope of changes.

what do you mean by "full scope", are you proposing we should update the old contentScripts api as well?

Comment 12

[Rob Wu [:robwu]]

(In reply to Tomislav Jovanovic :zombie from comment #11)

(In reply to Rob Wu [:robwu] from comment #10)

These days, the scripting API is the primary API to register content scripts and styles. Therefore I'm adjusting the title to reflect the full scope of changes.

what do you mean by "full scope", are you proposing we should update the old contentScripts api as well?

Initially this bug was about contentScripts only. I'm suggesting to expand it to scripting and the manifest key, because it does not make sense to add it to contentScripts.register only.

As the title shows, I'm suggesting to do it for all of the content script APIs, including contentScripts.

Last year I tried implementing a new content script field (match_origin_as_fallback in manifest - bug 1475831, and matchOriginAsFallback in the scripting API - bug 1853411), but initially not in contentScripts. That caused a regression in an extension (bug 1896669), so to minimize risk I also added the field to the existing contentScripts API.

Comment 13

[Christina]

Attachment: Bug 1679997 - Add cssOrigin to declarative contentScripts API. r=robwu.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d2f488f844f3
https://hg.mozilla.org/integration/autoland/rev/9b18a852f94b
Add cssOrigin to declarative contentScripts API. r=robwu.

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9b18a852f94b

Comment 17

[rbloor]

Documentation updates available in:

• (BCD) Bug-1679997 CSS origin for registered content scripts #27716
• (content) Bug-1679997 CSS origin for registered content scripts docs and release note #40955