Closed
Bug 1680002
Opened 3 years ago
Closed 3 years ago
Tests need to restore default environment
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Thunderbird
Add-Ons: Extensions API
Tracking
(thunderbird_esr78 wontfix, thunderbird84 wontfix)
RESOLVED
FIXED
85 Branch
People
(Reporter: TbSync, Assigned: TbSync)
Details
Attachments
(1 file, 2 obsolete files)
|
2.45 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
The test
- browser_ext_mailTabs.js
- browser_ext_menus.js
change the folderpane and tests after them fail (but not if they run on its own).
|
Assignee | |
Comment 1•3 years ago
|
||
Restore folder pane to default.
Attachment #9190529 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•3 years ago
|
||
Comment on attachment 9190529 [details] [diff] [review] bug1680002_tests_restore_default.patch Review of attachment 9190529 [details] [diff] [review]: ----------------------------------------------------------------- Usually a special function name, registerCleanupFunction, is used for cleanup.
Attachment #9190529 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Comment 3•3 years ago
|
||
Attachment #9190529 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•3 years ago
|
||
Comment on attachment 9190541 [details] [diff] [review]
bug1680002_tests_restore_default_2.patch
Using registerCleanupFunction() now.
Attachment #9190541 -
Flags: review?(mkmelin+mozilla)
|
|
||
Comment 5•3 years ago
|
||
Comment on attachment 9190541 [details] [diff] [review] bug1680002_tests_restore_default_2.patch Review of attachment 9190541 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9190541 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Updated•3 years ago
|
Keywords: checkin-needed-tb
|
|
Assignee | |
Updated•3 years ago
|
Keywords: checkin-needed-tb
|
|
Assignee | |
Comment 6•3 years ago
•
|
||
Eslint fixes. Sorry.
Attachment #9190541 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•3 years ago
|
Attachment #9190573 -
Flags: review?(mkmelin+mozilla)
|
|
||
Comment 7•3 years ago
|
||
Comment on attachment 9190573 [details] [diff] [review] bug1680002_tests_restore_default_2_eslint.patch Review of attachment 9190573 [details] [diff] [review]: ----------------------------------------------------------------- Thx, for such things just upload a new patch and mark it r+. I'll land this now
Attachment #9190573 -
Flags: review?(mkmelin+mozilla) → review+
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/a8a6afc8fc91
Tests need to restore default environment. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
|
|
||
Updated•3 years ago
|
status-thunderbird84:
--- → wontfix
status-thunderbird_esr78:
--- → wontfix
Target Milestone: --- → 85 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•